chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.h - Issue 1570783003: [Autofill] Move functions from the AutofillPopupController to AutofillPopupLayoutModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.h

Issue 1570783003: [Autofill] Move functions from the AutofillPopupController to AutofillPopupLayoutModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: size_t -> int Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/test_popup_controller_common.cc ('k') | chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.mm » ('j') | chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.h

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.h b/chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.h

index d9ea64bbf658e4443a5ee69bce115777c526d868..4b59b37e9b1030503ad1bc74dde387d43c75ca1f 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.h

+++ b/chrome/browser/ui/cocoa/autofill/autofill_popup_base_view_cocoa.h

@@ -15,7 +15,7 @@ class AutofillPopupViewDelegate;

@interface AutofillPopupBaseViewCocoa : BaseView {

@private

- autofill::AutofillPopupViewDelegate* delegate_; // weak

+ autofill::AutofillPopupViewDelegate* popup_delegate_; // weak

Ilya Sherman 2016/01/20 23:25:18 Why did you change this name?

Mathieu 2016/01/21 01:25:08 It conflicts with the |delegate_| in AutofillPopup

Ilya Sherman 2016/01/21 01:27:03 How does it conflict, exactly? That variable is i

}

- (NSColor*)backgroundColor;