Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_view_unittest.cc

Issue 1570783003: [Autofill] Move functions from the AutofillPopupController to AutofillPopupLayoutModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_view_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_popup_view_unittest.cc b/chrome/browser/ui/autofill/autofill_popup_view_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4329f6981535ae0a2d1a60acbae00fbb34693a12
--- /dev/null
+++ b/chrome/browser/ui/autofill/autofill_popup_view_unittest.cc
@@ -0,0 +1,114 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/autofill/autofill_popup_view.h"
+
+#include <stddef.h>
+
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/ui/autofill/autofill_popup_view_delegate.h"
+#include "chrome/browser/ui/autofill/popup_constants.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "components/autofill/core/browser/suggestion.h"
+#include "content/public/browser/web_contents.h"
+#include "grit/components_scaled_resources.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/resource/resource_bundle.h"
+#include "ui/gfx/geometry/point.h"
+#include "ui/gfx/geometry/rect.h"
+#include "ui/gfx/geometry/rect_f.h"
+#include "ui/gfx/native_widget_types.h"
+
+namespace autofill {
+
+namespace {
+
+class TestAutofillPopupViewDelegate : public AutofillPopupViewDelegate {
+ public:
+ explicit TestAutofillPopupViewDelegate(content::WebContents* web_contents)
+ : element_bounds_(0.0, 0.0, 100.0, 100.0),
+ container_view_(web_contents->GetNativeView()) {}
+
+ void Hide() override {}
+ void ViewDestroyed() override{};
+ void SetSelectionAtPoint(const gfx::Point& point) override {}
+ bool AcceptSelectedLine() override { return true; }
+ void SelectionCleared() override {}
+ gfx::Rect popup_bounds() const override { return gfx::Rect(0, 0, 100, 100); }
+ gfx::NativeView container_view() override { return container_view_; }
+ const gfx::RectF& element_bounds() const override { return element_bounds_; }
+ bool IsRTL() const override { return false; }
+
+ const std::vector<autofill::Suggestion> GetSuggestions() override {
+ // Give elements 1 and 3 subtexts and elements 2 and 3 icons, to ensure
+ // all combinations of subtexts and icons.
+ std::vector<Suggestion> suggestions;
+ suggestions.push_back(Suggestion("", "", "", 0));
+ suggestions.push_back(Suggestion("", "x", "", 0));
+ suggestions.push_back(Suggestion("", "", "americanExpressCC", 0));
+ suggestions.push_back(Suggestion("", "x", "genericCC", 0));
+ return suggestions;
+ }
+#if !defined(OS_ANDROID)
+ int GetElidedValueWidthForRow(size_t row) override { return 0; }
+ int GetElidedLabelWidthForRow(size_t row) override { return 0; }
+#endif
+
+ private:
+ gfx::RectF element_bounds_;
+ gfx::NativeView container_view_;
+};
+
+// Implementing the platform-specific bits of AutofillPopupView for testing.
+class TestAutofillPopupView : public AutofillPopupView {
+ public:
+ explicit TestAutofillPopupView(AutofillPopupViewDelegate* delegate)
+ : AutofillPopupView(delegate) {}
+
+ void Show() override {}
+ void Hide() override {}
+ void InvalidateRow(size_t row) override {}
+ void UpdateBoundsAndRedrawPopup() override {}
+};
+
+class AutofillPopupViewTest : public ChromeRenderViewHostTestHarness {
+ public:
+ void SetUp() override {
+ ChromeRenderViewHostTestHarness::SetUp();
+
+ delegate_.reset(new TestAutofillPopupViewDelegate(web_contents()));
+ view_.reset(new TestAutofillPopupView(delegate_.get()));
+ }
+
+ AutofillPopupView* view() { return view_.get(); }
+
+ private:
+ scoped_ptr<TestAutofillPopupViewDelegate> delegate_;
+ scoped_ptr<AutofillPopupView> view_;
+};
+
+} // namespace
+
+TEST_F(AutofillPopupViewTest, RowWidthWithoutText) {
+ int base_size =
+ AutofillPopupView::kEndPadding * 2 + kPopupBorderThickness * 2;
+ int subtext_increase = AutofillPopupView::kNamePadding;
+
+ // Refer to GetSuggestions() in TestAutofillPopupViewDelegate.
+ EXPECT_EQ(base_size, view()->RowWidthWithoutText(0, /* with_label= */ false));
+ EXPECT_EQ(base_size + subtext_increase,
+ view()->RowWidthWithoutText(1, /* with_label= */ true));
+ EXPECT_EQ(base_size + AutofillPopupView::kIconPadding +
+ ui::ResourceBundle::GetSharedInstance()
+ .GetImageNamed(IDR_AUTOFILL_CC_AMEX)
+ .Width(),
+ view()->RowWidthWithoutText(2, /* with_label= */ false));
+ EXPECT_EQ(base_size + subtext_increase + AutofillPopupView::kIconPadding +
+ ui::ResourceBundle::GetSharedInstance()
+ .GetImageNamed(IDR_AUTOFILL_CC_GENERIC)
+ .Width(),
+ view()->RowWidthWithoutText(3, /* with_label= */ true));
+}
+
+} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698