Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.h

Issue 1570783003: [Autofill] Move functions from the AutofillPopupController to AutofillPopupLayoutModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
index 0f408030344faedbf1c3f9718f4a00b0e0ccdfaa..bec7b1a204e1ada49fd3d40aabdf178c8e93fb12 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h
@@ -5,12 +5,14 @@
#ifndef CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_IMPL_H_
#define CHROME_BROWSER_UI_AUTOFILL_PASSWORD_GENERATION_POPUP_CONTROLLER_IMPL_H_
+#include <stddef.h>
#include <string>
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "chrome/browser/ui/autofill/password_generation_popup_controller.h"
#include "chrome/browser/ui/autofill/popup_controller_common.h"
+#include "chrome/browser/ui/autofill/popup_view_utils.h"
#include "components/autofill/core/common/password_form.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/rect_f.h"
@@ -32,6 +34,7 @@ namespace autofill {
class PasswordGenerator;
class PasswordGenerationPopupObserver;
class PasswordGenerationPopupView;
+struct Suggestion;
// This class controls a PasswordGenerationPopupView. It is responsible for
// determining the location of the popup, handling keypress events while the
@@ -98,9 +101,15 @@ class PasswordGenerationPopupControllerImpl
void OnSavedPasswordsLinkClicked() override;
int GetMinimumWidth() override;
gfx::NativeView container_view() override;
- const gfx::Rect& popup_bounds() const override;
+ gfx::Rect popup_bounds() const override;
const gfx::RectF& element_bounds() const override;
bool IsRTL() const override;
+ const std::vector<autofill::Suggestion> GetSuggestions() override;
+#if !defined(OS_ANDROID)
+ int GetElidedValueWidthForRow(size_t row) override;
+ int GetElidedLabelWidthForRow(size_t row) override;
+#endif
+
bool display_password() const override;
bool password_selected() const override;
base::string16 password() const override;
@@ -149,6 +158,8 @@ class PasswordGenerationPopupControllerImpl
// Bounds for all the elements of the popup.
gfx::Rect popup_bounds_;
+ autofill::view_utils::PopupViewUtils view_utils_;
+
base::WeakPtrFactory<PasswordGenerationPopupControllerImpl> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(PasswordGenerationPopupControllerImpl);

Powered by Google App Engine
This is Rietveld 408576698