Add class extensions::InputImeEventRouterBase

Add class extensions::InputImeEventRouterBase

As Chrome desktop needs not to provide system level IME switching UI, the InputImeEventRouter and InputImeAPI related functions are different on Chrome OS and non Chrome OS. Thus, class extensions::InputImeEventRouterBase is added to reuse the common codes, and implementation of InputImeAPI functions are divided into input_ime_api_chromos.cc/input_ime_api_nonchromeos.cc.

BUG=517773
TEST=Verified bug not repro on local build.

Committed: https://crrev.com/131167b3befbbae26e431ab22eaa6a2c37ee0de0
Cr-Commit-Position: refs/heads/master@{#368784}

[Azure Wei, 2016-01-08 07:45:46]

Description was changed from

==========
Add class extensions::InputImeEventRouterBase

As Chrome desktop needs not to provide system level IME switching UI, the
InputImeEventRouter and InputImeAPI related functions are different on Chrome OS
and non Chrome OS. Thus, class extensions::InputImeEventRouterBase is added to
reuse the common codes, and implementation of InputImeAPI functions are divided
into input_ime_api_chromos.cc/input_ime_api_nonchromeos.cc.

BUG=517773
TEST=Verified bug not repro on local build.
==========

to

==========
Add class extensions::InputImeEventRouterBase

As Chrome desktop needs not to provide system level IME switching UI, the
InputImeEventRouter and InputImeAPI related functions are different on Chrome OS
and non Chrome OS. Thus, class extensions::InputImeEventRouterBase is added to
reuse the common codes, and implementation of InputImeAPI functions are divided
into input_ime_api_chromos.cc/input_ime_api_nonchromeos.cc.

BUG=517773
TEST=Verified bug not repro on local build.
==========

[Azure Wei, 2016-01-08 07:45:46]

azurewei@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, shuchen@chromium.org

[Azure Wei, 2016-01-08 07:52:27]

Hi Shu Chen and Devlin, can you please take a look at this cl? Thank you!
The code changes are the same with Patch Set 9 of Cl:
https://codereview.chromium.org/1554983002/, except for no changing with the GN
files.
Thus, that cl will only focus on GN changes after rebasing.

[Shu Chen, 2016-01-08 08:04:40]

lgtm

[Devlin, 2016-01-11 22:18:57]

lgtm with nits

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc (right):

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc:366: if (it !=
engine_map_.end())
ternary

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc:368: return
NULL;
prefer nullptr

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc:375: if (it !=
engine_map_.end() && it->second->IsActive())
same as above

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.h (right):

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.h:17: class
InputImeEventRouterBase;
you include the header, so no need for this.

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/input_ime/input_ime_event_router_base.h
(right):

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_event_router_base.h:16: class
Profile;
#include'd things don't have to be forward declared.

[Azure Wei, 2016-01-12 01:55:54]

Thanks for your review.

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc (right):

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc:366: if (it !=
engine_map_.end())
On 2016/01/11 22:18:57, Devlin wrote:
> ternary

Done.

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc:368: return
NULL;
On 2016/01/11 22:18:57, Devlin wrote:
> prefer nullptr

Done.

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc:375: if (it !=
engine_map_.end() && it->second->IsActive())
On 2016/01/11 22:18:57, Devlin wrote:
> same as above

Done.

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.h (right):

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.h:17: class
InputImeEventRouterBase;
On 2016/01/11 22:18:57, Devlin wrote:
> you include the header, so no need for this.

Done.

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/input_ime/input_ime_event_router_base.h
(right):

https://codereview.chromium.org/1570723002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/input_ime/input_ime_event_router_base.h:16: class
Profile;
On 2016/01/11 22:18:57, Devlin wrote:
> #include'd things don't have to be forward declared.

Done.

[Azure Wei, 2016-01-12 01:55:58]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-12 01:56:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570723002/40001

[commit-bot: I haz the power, 2016-01-12 02:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 02:43:43]

Dry run: This issue passed the CQ dry run.

[Azure Wei, 2016-01-12 02:43:53]

The CQ bit was checked by azurewei@chromium.org

[Azure Wei, 2016-01-12 02:43:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
shuchen@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1570723002/#ps40001
(title: "Addressed Devlin's comments.")

[commit-bot: I haz the power, 2016-01-12 02:44:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570723002/40001

[commit-bot: I haz the power, 2016-01-12 02:49:53]

Description was changed from

==========
Add class extensions::InputImeEventRouterBase

As Chrome desktop needs not to provide system level IME switching UI, the
InputImeEventRouter and InputImeAPI related functions are different on Chrome OS
and non Chrome OS. Thus, class extensions::InputImeEventRouterBase is added to
reuse the common codes, and implementation of InputImeAPI functions are divided
into input_ime_api_chromos.cc/input_ime_api_nonchromeos.cc.

BUG=517773
TEST=Verified bug not repro on local build.
==========

to

==========
Add class extensions::InputImeEventRouterBase

As Chrome desktop needs not to provide system level IME switching UI, the
InputImeEventRouter and InputImeAPI related functions are different on Chrome OS
and non Chrome OS. Thus, class extensions::InputImeEventRouterBase is added to
reuse the common codes, and implementation of InputImeAPI functions are divided
into input_ime_api_chromos.cc/input_ime_api_nonchromeos.cc.

BUG=517773
TEST=Verified bug not repro on local build.
==========

[commit-bot: I haz the power, 2016-01-12 02:49:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 02:50:44]

Description was changed from

==========
Add class extensions::InputImeEventRouterBase

As Chrome desktop needs not to provide system level IME switching UI, the
InputImeEventRouter and InputImeAPI related functions are different on Chrome OS
and non Chrome OS. Thus, class extensions::InputImeEventRouterBase is added to
reuse the common codes, and implementation of InputImeAPI functions are divided
into input_ime_api_chromos.cc/input_ime_api_nonchromeos.cc.

BUG=517773
TEST=Verified bug not repro on local build.
==========

to

==========
Add class extensions::InputImeEventRouterBase

As Chrome desktop needs not to provide system level IME switching UI, the
InputImeEventRouter and InputImeAPI related functions are different on Chrome OS
and non Chrome OS. Thus, class extensions::InputImeEventRouterBase is added to
reuse the common codes, and implementation of InputImeAPI functions are divided
into input_ime_api_chromos.cc/input_ime_api_nonchromeos.cc.

BUG=517773
TEST=Verified bug not repro on local build.

Committed: https://crrev.com/131167b3befbbae26e431ab22eaa6a2c37ee0de0
Cr-Commit-Position: refs/heads/master@{#368784}
==========

[commit-bot: I haz the power, 2016-01-12 02:50:44]

Patchset 3 (id:??) landed as
https://crrev.com/131167b3befbbae26e431ab22eaa6a2c37ee0de0
Cr-Commit-Position: refs/heads/master@{#368784}