Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1570643002:
GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() (Closed)
DescriptionGLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes()
The IsUDL() call always returns false if no overlay planes are queued.
BUG=569075
TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1564123002
TBR=dnicoara@chromium.org
Cr-Commit-Position: refs/heads/master@{#368155}
(cherry picked from commit 66cf41e2641eadf9954c6c108eae235880e3a245)
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() The IsUDL() call always returns false if no overlay planes are queued. BUG=569075 TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL Review URL: https://codereview.chromium.org/1564123002 Cr-Commit-Position: refs/heads/master@{#368155} (cherry picked from commit 66cf41e2641eadf9954c6c108eae235880e3a245) ========== to ========== GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() The IsUDL() call always returns false if no overlay planes are queued. BUG=569075 TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL Review URL: https://codereview.chromium.org/1564123002 TBR=dnicoara@chromium.org Cr-Commit-Position: refs/heads/master@{#368155} (cherry picked from commit 66cf41e2641eadf9954c6c108eae235880e3a245) ==========
hshi@chromium.org changed reviewers: + josafat@chromium.org
josafat@ -- need to merge this to branch 48 (see bug 569075)
The CQ bit was checked by hshi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570643002/1
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() The IsUDL() call always returns false if no overlay planes are queued. BUG=569075 TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL Review URL: https://codereview.chromium.org/1564123002 TBR=dnicoara@chromium.org Cr-Commit-Position: refs/heads/master@{#368155} (cherry picked from commit 66cf41e2641eadf9954c6c108eae235880e3a245) ========== to ========== GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() The IsUDL() call always returns false if no overlay planes are queued. BUG=569075 TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL NOTRY=true NOSUBMIT=true Review URL: https://codereview.chromium.org/1564123002 TBR=dnicoara@chromium.org Cr-Commit-Position: refs/heads/master@{#368155} (cherry picked from commit 66cf41e2641eadf9954c6c108eae235880e3a245) ==========
The CQ bit was checked by hshi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570643002/1
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
Description was changed from ========== GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() The IsUDL() call always returns false if no overlay planes are queued. BUG=569075 TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL NOTRY=true NOSUBMIT=true Review URL: https://codereview.chromium.org/1564123002 TBR=dnicoara@chromium.org Cr-Commit-Position: refs/heads/master@{#368155} (cherry picked from commit 66cf41e2641eadf9954c6c108eae235880e3a245) ========== to ========== GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() The IsUDL() call always returns false if no overlay planes are queued. BUG=569075 TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1564123002 TBR=dnicoara@chromium.org Cr-Commit-Position: refs/heads/master@{#368155} (cherry picked from commit 66cf41e2641eadf9954c6c108eae235880e3a245) ==========
The CQ bit was checked by hshi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570643002/1
Message was sent while issue was closed.
Description was changed from ========== GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() The IsUDL() call always returns false if no overlay planes are queued. BUG=569075 TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1564123002 TBR=dnicoara@chromium.org Cr-Commit-Position: refs/heads/master@{#368155} (cherry picked from commit 66cf41e2641eadf9954c6c108eae235880e3a245) ========== to ========== GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() The IsUDL() call always returns false if no overlay planes are queued. BUG=569075 TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1564123002 TBR=dnicoara@chromium.org Cr-Commit-Position: refs/heads/master@{#368155} (cherry picked from commit 66cf41e2641eadf9954c6c108eae235880e3a245) ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
