Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1564123002: GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() (Closed)

Created:
4 years, 11 months ago by hshi1
Modified:
4 years, 11 months ago
Reviewers:
dnicoara, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GLSurfaceOzone: move the IsUDL() check after ScheduleOverlayPlanes() The IsUDL() call always returns false if no overlay planes are queued. BUG=569075 TEST=Verified that IsUniversalDisplayLinkDevice() returns true for UDL Committed: https://crrev.com/66cf41e2641eadf9954c6c108eae235880e3a245 Cr-Commit-Position: refs/heads/master@{#368155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M ui/gl/gl_surface_ozone.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hshi1
PTAL. This seems to work and I think it is a more correct fix.
4 years, 11 months ago (2016-01-07 20:15:45 UTC) #2
dnicoara
lgtm
4 years, 11 months ago (2016-01-07 20:54:07 UTC) #3
spang
lgtm thanks for tracking down this regression :(
4 years, 11 months ago (2016-01-07 21:04:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564123002/1
4 years, 11 months ago (2016-01-07 21:04:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-07 21:10:30 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 21:11:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66cf41e2641eadf9954c6c108eae235880e3a245
Cr-Commit-Position: refs/heads/master@{#368155}

Powered by Google App Engine
This is Rietveld 408576698