[Interpreter] Add support for CallRuntimeForPair to Bytecode Graph Builder.

[Interpreter] Add support for CallRuntimeForPair to Bytecode Graph Builder.

Adds support for the CallRuntimeForPair bytecode to the Bytecode Graph
Builder. Modifies the FrameState support to allow updating of output
registers.

Also adds Eval tests to test-run-bytecode-graph-builder since these are
enabled by CallRuntimeForPair support.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/b261976cc018c0fb77429345c712afe5ad9c3959
Cr-Commit-Position: refs/heads/master@{#33186}

[rmcilroy, 2016-01-08 11:46:38]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2016-01-08 11:47:23]

rmcilroy@chromium.org changed reviewers:
+ jarin@chromium.org, oth@chromium.org

[rmcilroy, 2016-01-08 11:47:24]

Jaro, Orion, please take a look, thanks.

[Jarin, 2016-01-08 12:32:55]

lgtm. Thanks for removing the AccumulatorUpdateMode enum!

https://codereview.chromium.org/1570623007/diff/20001/src/compiler/bytecode-g...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/1570623007/diff/20001/src/compiler/bytecode-g...
src/compiler/bytecode-graph-builder.cc:208: if (states) {
I think you should check that 'node->op()->ValueOutputCount() == count' (either
here or in AddToNode). Otherwise, the deopt will not do what you want.

[rmcilroy, 2016-01-08 14:47:20]

https://codereview.chromium.org/1570623007/diff/20001/src/compiler/bytecode-g...
File src/compiler/bytecode-graph-builder.cc (right):

https://codereview.chromium.org/1570623007/diff/20001/src/compiler/bytecode-g...
src/compiler/bytecode-graph-builder.cc:208: if (states) {
On 2016/01/08 12:32:55, Jarin wrote:
> I think you should check that 'node->op()->ValueOutputCount() == count'
(either
> here or in AddToNode). Otherwise, the deopt will not do what you want.

Right, actually I think we should just use node->op()->ValueOutputCount() rather
than passing a seperate count around, WDYT?

[oth, 2016-01-08 14:56:00]

lgtm but ianae in this area.

[Jarin, 2016-01-08 15:02:57]

On 2016/01/08 14:47:20, rmcilroy wrote:

> Right, actually I think we should just use node->op()->ValueOutputCount()
rather
> than passing a seperate count around, WDYT?

Makes sense (I originally thought you would get some extra checking with the
dcheck, but now I see that it does not bring any extra value). Thanks.

[rmcilroy, 2016-01-08 15:17:38]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 15:17:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570623007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570623007/60001

[commit-bot: I haz the power, 2016-01-08 15:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 15:46:23]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12168)

[rmcilroy, 2016-01-08 16:05:36]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-01-08 16:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
oth@chromium.org
Link to the patchset: https://codereview.chromium.org/1570623007/#ps80001
(title: "Fix test flags")

[commit-bot: I haz the power, 2016-01-08 16:05:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570623007/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570623007/80001

[commit-bot: I haz the power, 2016-01-08 16:40:37]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-01-08 16:41:03]

Description was changed from

==========
[Interpreter] Add support for CallRuntimeForPair to Bytecode Graph Builder.

Adds support for the CallRuntimeForPair bytecode to the Bytecode Graph
Builder. Modifies the FrameState support to allow updating of output
registers.

Also adds Eval tests to test-run-bytecode-graph-builder since these are
enabled by CallRuntimeForPair support.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Add support for CallRuntimeForPair to Bytecode Graph Builder.

Adds support for the CallRuntimeForPair bytecode to the Bytecode Graph
Builder. Modifies the FrameState support to allow updating of output
registers.

Also adds Eval tests to test-run-bytecode-graph-builder since these are
enabled by CallRuntimeForPair support.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/b261976cc018c0fb77429345c712afe5ad9c3959
Cr-Commit-Position: refs/heads/master@{#33186}
==========

[commit-bot: I haz the power, 2016-01-08 16:41:04]

Patchset 4 (id:??) landed as
https://crrev.com/b261976cc018c0fb77429345c712afe5ad9c3959
Cr-Commit-Position: refs/heads/master@{#33186}