Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1568323002: [Interpreter] Add support for LOOKUP_SLOT_CALL to interpreter. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
oth, mythria
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_eval_graph
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for LOOKUP_SLOT_CALL to interpreter. Adds support for LOOKUP_SLOT_CALL calls to the interpreter. Also changes VisitCall to keep callee and reciever consecutive to avoid register shuffles when performing LOOKUP_SLOT_CALL calls. Adds tests for the interpreter and bytecode graph generator. BUG=v8:4280 LOG=N Committed: https://crrev.com/d00c4666a4dd78c74a89d27e0690c994759cf869 Cr-Commit-Position: refs/heads/master@{#33237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -32 lines) Patch
M src/interpreter/bytecode-generator.cc View 4 chunks +11 lines, -16 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 9 chunks +83 lines, -16 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
rmcilroy
Orion / Mythri, PTAL, thanks.
4 years, 11 months ago (2016-01-08 16:28:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568323002/1
4 years, 11 months ago (2016-01-08 16:28:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 16:52:53 UTC) #6
rmcilroy
Ping?
4 years, 11 months ago (2016-01-12 10:49:26 UTC) #7
mythria
lgtm Thanks, Mythri
4 years, 11 months ago (2016-01-12 11:02:55 UTC) #8
oth
lgtm
4 years, 11 months ago (2016-01-12 11:30:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568323002/1
4 years, 11 months ago (2016-01-12 12:45:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 13:11:33 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 13:12:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d00c4666a4dd78c74a89d27e0690c994759cf869
Cr-Commit-Position: refs/heads/master@{#33237}

Powered by Google App Engine
This is Rietveld 408576698