Issue 1570543002: Add VMULS and VMULD instructions to integrated ARM assembler.

Issue 1570543002: Add VMULS and VMULD instructions to integrated ARM assembler. (Closed)

Created:
4 years, 11 months ago by Karl

Modified:
4 years, 11 months ago

Reviewers:
Jim Stichnoth, sehr, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add VMULS and VMULD instructions to integrated ARM assembler. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8a105fd788ba9bcdd4aa2b154d166e89b1a2337e

Patch Set 2 : Add comments to DART assembler file. #

Patch Set 3 : Show resolved merge conflicts. #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -24 lines)			Patch
M	src/DartARM32/assembler_arm.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/DartARM32/assembler_arm.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/IceAssemblerARM32.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/IceAssemblerARM32.cpp	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
M	src/IceInstARM32.cpp	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
A +	tests_lit/assembler/arm32/vmul.ll	View	1 2	2 chunks	+23 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

lgtm https://codereview.chromium.org/1570543002/diff/1/src/DartARM32/assembler_arm.h File src/DartARM32/assembler_arm.h (right): https://codereview.chromium.org/1570543002/diff/1/src/DartARM32/assembler_arm.h#newcode662 src/DartARM32/assembler_arm.h:662: #if 0 Add the usual comments about where ...

4 years, 11 months ago (2016-01-07 18:04:17 UTC) #3

Karl

Committed patchset #3 (id:40001) manually as 8a105fd788ba9bcdd4aa2b154d166e89b1a2337e (presubmit successful).

4 years, 11 months ago (2016-01-07 21:46:23 UTC) #5

Karl

4 years, 11 months ago (2016-01-07 21:46:35 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/1570543002/diff/1/src/DartARM32/assembler_arm.h
File src/DartARM32/assembler_arm.h (right):

https://codereview.chromium.org/1570543002/diff/1/src/DartARM32/assembler_arm...
src/DartARM32/assembler_arm.h:662: #if 0
On 2016/01/07 18:04:17, stichnot wrote:
> Add the usual comments about where these moved?

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages