Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1570513005: Revert of Avoid LSan false positives from CSSPathValue::emptyValue(). (Closed)

Created:
4 years, 11 months ago by Marc Treib
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, sof
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid LSan false positives from CSSPathValue::emptyValue(). (patchset #1 id:1 of https://codereview.chromium.org/1566423002/ ) Reason for revert: Broke Cast Android (dbg) build: https://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20(dbg) Original issue's description: > Avoid LSan false positives from CSSPathValue::emptyValue(). > > LSan reports a leak on SVGComputedStyleTest.MiscStyleShouldCompareValue > (with Oilpan), stemming from emptyValue()'s allocation of an > SVGPathByteStream object. Introduce a local constructor function that > explicitly keeps this sub-object from LSan's view -- it is owned by > the emptyValue singleton and shouldn't be considered a leak. > > R=haraken > BUG= > > Committed: https://crrev.com/08494b981bbe6e9925ffd6663e65b6151bdd9425 > Cr-Commit-Position: refs/heads/master@{#368329} TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/0c2bd4e98d84974bf5f302f70c16bade6265b5c0 Cr-Commit-Position: refs/heads/master@{#368330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M third_party/WebKit/Source/core/css/CSSPathValue.cpp View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Marc Treib
Created Revert of Avoid LSan false positives from CSSPathValue::emptyValue().
4 years, 11 months ago (2016-01-08 14:52:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570513005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570513005/1
4 years, 11 months ago (2016-01-08 14:53:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 14:54:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0c2bd4e98d84974bf5f302f70c16bade6265b5c0 Cr-Commit-Position: refs/heads/master@{#368330}
4 years, 11 months ago (2016-01-08 14:55:15 UTC) #5
sof
4 years, 11 months ago (2016-01-08 14:56:11 UTC) #6
Message was sent while issue was closed.
lgtm, thanks for the revert. r368320 changed SVGPathByteStream to be
ref-counted.

Powered by Google App Engine
This is Rietveld 408576698