Chromium Code Reviews
DescriptionFix FullscreenController tests with simplified-fullscreen-ui flag.
Running browser_tests and interactive_ui_tests with
--enable-simplified-fullscreen-ui now passes. (This is not currently run
on any bots, but a flag flip will follow.)
Also fixed FullscreenOnFileURL to test fullscreen, not mouse lock
(previously this test was identical to MouseLockOnFileURL).
Note: Previously none of the tests were actually locking the mouse and
testing that the bubble was displayed (now we are forced to do that). It
turns out this never worked because calling Browser::RequestToLockMouse
is not sufficient to lock the mouse. Added a fake flag that tells the
mouse lock controller to simulate locking the mouse so we can test the
bubble.
BUG=352425
Committed: https://crrev.com/8a6b6824cc9d4095ef3ec5c8c01f937b9f3ccabf
Cr-Commit-Position: refs/heads/master@{#368283}
Patch Set 1 #Patch Set 2 : FullscreenControllerInteractiveTest: Further fixes for ChromeOS-only tests. #
Dependent Patchsets: Messages
Total messages: 13 (5 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||