Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 1570443008: Fix FullscreenController tests with simplified-fullscreen-ui flag. (Closed)

Created:
4 years, 11 months ago by Matt Giuca
Modified:
4 years, 11 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix FullscreenController tests with simplified-fullscreen-ui flag. Running browser_tests and interactive_ui_tests with --enable-simplified-fullscreen-ui now passes. (This is not currently run on any bots, but a flag flip will follow.) Also fixed FullscreenOnFileURL to test fullscreen, not mouse lock (previously this test was identical to MouseLockOnFileURL). Note: Previously none of the tests were actually locking the mouse and testing that the bubble was displayed (now we are forced to do that). It turns out this never worked because calling Browser::RequestToLockMouse is not sufficient to lock the mouse. Added a fake flag that tells the mouse lock controller to simulate locking the mouse so we can test the bubble. BUG=352425 Committed: https://crrev.com/8a6b6824cc9d4095ef3ec5c8c01f937b9f3ccabf Cr-Commit-Position: refs/heads/master@{#368283}

Patch Set 1 #

Patch Set 2 : FullscreenControllerInteractiveTest: Further fixes for ChromeOS-only tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -43 lines) Patch
M chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc View 5 chunks +37 lines, -13 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc View 1 4 chunks +51 lines, -27 lines 0 comments Download
M chrome/browser/ui/exclusive_access/fullscreen_controller_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/exclusive_access/mouse_lock_controller.h View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/exclusive_access/mouse_lock_controller.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
Matt Giuca
4 years, 11 months ago (2016-01-08 02:44:51 UTC) #2
Matt Giuca
4 years, 11 months ago (2016-01-08 02:45:17 UTC) #4
scheib
LGTM
4 years, 11 months ago (2016-01-08 03:11:00 UTC) #5
Matt Giuca
I had to fix some more tests after LGTM that were broken on Win/ChromeOS. The ...
4 years, 11 months ago (2016-01-08 04:59:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570443008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570443008/20001
4 years, 11 months ago (2016-01-08 05:00:00 UTC) #9
Matt Giuca
On 2016/01/08 04:59:12, Matt Giuca wrote: > I had to fix some more tests after ...
4 years, 11 months ago (2016-01-08 05:01:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 05:55:12 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 05:55:57 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a6b6824cc9d4095ef3ec5c8c01f937b9f3ccabf
Cr-Commit-Position: refs/heads/master@{#368283}

Powered by Google App Engine
This is Rietveld 408576698