Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1564783004: Enable the simplified-fullscreen-ui flag by default on Aura. (Closed)

Created:
4 years, 11 months ago by Matt Giuca
Modified:
4 years, 11 months ago
Reviewers:
scheib, egm, egm1
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, msw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable the simplified-fullscreen-ui flag by default on Aura. This changes the behaviour and appearance of the fullscreen and mouse lock bubble on Windows, Linux and Chrome OS. Other platforms are unaffected. BUG=352425 Committed: https://crrev.com/96b7806c560d2ab431c043df7e1b309a75486409 Cr-Commit-Position: refs/heads/master@{#368295}

Patch Set 1 #

Patch Set 2 : Fix tests (will split into separate CL before landing). #

Patch Set 3 : FullscreenControllerInteractiveTest: Further fixes for ChromeOS-only tests. #

Patch Set 4 : Factor out test fixes to CL 1570443008. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/exclusive_access/exclusive_access_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (9 generated)
Matt Giuca
It's time to enable this by default on dev (I don't think there are any ...
4 years, 11 months ago (2016-01-07 05:07:37 UTC) #2
Matt Giuca
scheib: Code / OWNERS. egm: PM decision to flip flag. msw: FYI since you have ...
4 years, 11 months ago (2016-01-07 05:08:38 UTC) #3
scheib
On 2016/01/07 05:08:38, Matt Giuca wrote: > scheib: Code / OWNERS. LGTM
4 years, 11 months ago (2016-01-07 18:17:29 UTC) #4
egm1
On 2016/01/07 05:08:38, Matt Giuca wrote: > scheib: Code / OWNERS. > egm: PM decision ...
4 years, 11 months ago (2016-01-07 20:16:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564783004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564783004/1
4 years, 11 months ago (2016-01-07 23:22:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/149525)
4 years, 11 months ago (2016-01-07 23:54:52 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564783004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564783004/20001
4 years, 11 months ago (2016-01-08 02:37:44 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564783004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564783004/60001
4 years, 11 months ago (2016-01-08 04:18:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1564783004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1564783004/80001
4 years, 11 months ago (2016-01-08 07:40:04 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 11 months ago (2016-01-08 08:16:20 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 08:17:12 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/96b7806c560d2ab431c043df7e1b309a75486409
Cr-Commit-Position: refs/heads/master@{#368295}

Powered by Google App Engine
This is Rietveld 408576698