styleguide: Ban ref-qualified member functions, <atomic>, std::shared_ptr and std::initializer_list.

styleguide: Ban ref-qualified member functions, <atomic>, std::shared_ptr and std::initializer_list.

NOTRY=true

Committed: https://crrev.com/d21995c5b183ae0dbc3f46f9ab959986b877efd8
Cr-Commit-Position: refs/heads/master@{#368198}

[jbroman, 2016-01-07 22:26:22]

jbroman@chromium.org changed reviewers:
+ danakj@chromium.org, thakis@chromium.org

[Nico, 2016-01-07 22:40:36]

initializer_list too?

https://codereview.chromium.org/1570443005/diff/1/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1570443005/diff/1/styleguide/c++/c++11.html#n...
styleguide/c++/c++11.html:557: <td>Banned in the google3 C++11 library style
guide. Banned in Chromium except by explicit approval.</td>
Can you add a Discussion thread link here?

https://codereview.chromium.org/1570443005/diff/1/styleguide/c++/c++11.html#n...
styleguide/c++/c++11.html:618: <a
href="https://google.github.io/styleguide/cppguide.html#Ownership_and_Smart_Pointers">Ownership
and Smart Pointers</a>
Here too

[jbroman, 2016-01-07 23:26:05]

Description was changed from

==========
styleguide: Ban ref-qualified member functions, <atomic> and std::shared_ptr.

NOTRY=true
==========

to

==========
styleguide: Ban ref-qualified member functions, <atomic>, std::shared_ptr and
std::initializer_list.

NOTRY=true
==========

[jbroman, 2016-01-07 23:26:33]

Also added std::initializer_list, which I'd missed.

https://codereview.chromium.org/1570443005/diff/1/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1570443005/diff/1/styleguide/c++/c++11.html#n...
styleguide/c++/c++11.html:557: <td>Banned in the google3 C++11 library style
guide. Banned in Chromium except by explicit approval.</td>
On 2016/01/07 at 22:40:36, Nico wrote:
> Can you add a Discussion thread link here?

Done.

https://codereview.chromium.org/1570443005/diff/1/styleguide/c++/c++11.html#n...
styleguide/c++/c++11.html:618: <a
href="https://google.github.io/styleguide/cppguide.html#Ownership_and_Smart_Pointers">Ownership
and Smart Pointers</a>
On 2016/01/07 at 22:40:36, Nico wrote:
> Here too

Done.

[Nico, 2016-01-07 23:28:07]

lgtm, thanks!

[danakj, 2016-01-07 23:32:40]

LGTM

https://codereview.chromium.org/1570443005/diff/20001/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1570443005/diff/20001/styleguide/c++/c++11.ht...
styleguide/c++/c++11.html:558: Banned in the google3 C++11 library style guide.
Banned in Chromium except by explicit approval.
maybe worth saying approval by whom

[jbroman, 2016-01-07 23:38:10]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-01-07 23:38:11]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1570443005/#ps40001
(title: "specify who can approve ref-qualified member functions")

[jbroman, 2016-01-07 23:38:33]

https://codereview.chromium.org/1570443005/diff/20001/styleguide/c++/c++11.html
File styleguide/c++/c++11.html (right):

https://codereview.chromium.org/1570443005/diff/20001/styleguide/c++/c++11.ht...
styleguide/c++/c++11.html:558: Banned in the google3 C++11 library style guide.
Banned in Chromium except by explicit approval.
On 2016/01/07 at 23:32:39, danakj (behind on reviews) wrote:
> maybe worth saying approval by whom

Done.

[commit-bot: I haz the power, 2016-01-07 23:38:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570443005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570443005/40001

[commit-bot: I haz the power, 2016-01-07 23:44:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-07 23:45:11]

Description was changed from

==========
styleguide: Ban ref-qualified member functions, <atomic>, std::shared_ptr and
std::initializer_list.

NOTRY=true
==========

to

==========
styleguide: Ban ref-qualified member functions, <atomic>, std::shared_ptr and
std::initializer_list.

NOTRY=true

Committed: https://crrev.com/d21995c5b183ae0dbc3f46f9ab959986b877efd8
Cr-Commit-Position: refs/heads/master@{#368198}
==========

[commit-bot: I haz the power, 2016-01-07 23:45:11]

Patchset 3 (id:??) landed as
https://crrev.com/d21995c5b183ae0dbc3f46f9ab959986b877efd8
Cr-Commit-Position: refs/heads/master@{#368198}