Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1570413002: Get rid of unnecessary weak pointer cleanup. (Closed)

Created:
4 years, 11 months ago by szager1
Modified:
4 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of unnecessary weak pointer cleanup. BUG=540528 R=haraken@chromium.org Committed: https://crrev.com/0207c69014fab8e34db458119c28a96783c260ec Cr-Commit-Position: refs/heads/master@{#368542}

Patch Set 1 #

Patch Set 2 : Add ASSERT(m_target) where appropriate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 1 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
szager1
4 years, 11 months ago (2016-01-10 05:15:12 UTC) #1
tfarina
Could you describe in the CL description why it is unnecessary?
4 years, 11 months ago (2016-01-10 11:39:24 UTC) #2
haraken
LGTM
4 years, 11 months ago (2016-01-10 12:25:27 UTC) #3
szager1
Added ASSERT(m_target) in a few places. PTAL
4 years, 11 months ago (2016-01-10 17:21:27 UTC) #4
haraken
LGTM
4 years, 11 months ago (2016-01-11 01:51:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570413002/20001
4 years, 11 months ago (2016-01-11 03:06:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-11 09:10:51 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 09:13:03 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0207c69014fab8e34db458119c28a96783c260ec
Cr-Commit-Position: refs/heads/master@{#368542}

Powered by Google App Engine
This is Rietveld 408576698