third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp - Issue 1570413002: Get rid of unnecessary weak pointer cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

Issue 1570413002: Get rid of unnecessary weak pointer cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Add ASSERT(m_target) where appropriate Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

diff --git a/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp b/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

index efa81ffa5ab50bc138a574b2bba573c8e8c4d437..32b8d5733df148dad9f0dc2371d4a87046c968f8 100644

--- a/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

+++ b/third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp

@@ -67,12 +67,6 @@ void ElementIntersectionObserverData::deactivateAllIntersectionObservers(Element

#if !ENABLE(OILPAN)

void ElementIntersectionObserverData::dispose()

{

- HeapVector<Member<IntersectionObservation>> observationsToDisconnect;

- copyValuesToVector(m_intersectionObservations, observationsToDisconnect);

- for (auto& observation : observationsToDisconnect)

- observation->disconnect();

- ASSERT(m_intersectionObservations.isEmpty());

HeapVector<Member<IntersectionObserver>> observersToDisconnect;

copyToVector(m_intersectionObservers, observersToDisconnect);

for (auto& observer : observersToDisconnect)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('j') | no next file with comments »