content/browser/renderer_host/render_widget_host_view_android.cc - Issue 157033007: API to Convert Java Bitmap Config to SkBitmap::Config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 157033007: API to Convert Java Bitmap Config to SkBitmap::Config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code changed as per review comments. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/content_view_core_impl.h ('K') | « content/browser/renderer_host/render_widget_host_view_android.h ('k') | content/public/browser/android/content_view_core.h » ('j') | ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 4f1c64d810b30557b4b3434ce3de598a3915c4f4..0a6663abf5f0b3f6f5ff3b163a2de14906b22351 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -262,6 +262,7 @@ void RenderWidgetHostViewAndroid::SetBounds(const gfx::Rect& rect) {

void RenderWidgetHostViewAndroid::GetScaledContentBitmap(

float scale,

gfx::Size* out_size,

+ SkBitmap::Config bitmap_config,

const base::Callback<void(bool, const SkBitmap&)>& result_callback) {

if (!IsSurfaceAvailableForCopy()) {

result_callback.Run(false, SkBitmap());

@@ -278,7 +279,7 @@ void RenderWidgetHostViewAndroid::GetScaledContentBitmap(

gfx::ToCeiledSize(gfx::ScaleSize(bounds, scale / device_scale_factor)));

*out_size = dst_size;

CopyFromCompositingSurface(

- src_subrect, dst_size, result_callback, SkBitmap::kARGB_8888_Config);

+ src_subrect, dst_size, result_callback, bitmap_config);

}

bool RenderWidgetHostViewAndroid::PopulateBitmapWithContents(jobject jbitmap) {