API to Convert Java Bitmap Config to SkBitmap::Config

content/browser/android/content_view_core_impl.h

Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index 746421066247a07330d048aabb2b090e19f35170..d0221e0ea94525af0a410307d5d57387d6d1046e 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -60,6 +60,7 @@ class ContentViewCoreImpl : public ContentViewCore,
   virtual void GetScaledContentBitmap(
       float scale,
       gfx::Size* out_size,
+      jobject bitmap_config,

[powei, 2014/02/13 18:30:11]

Thanks for the hard work.  Would you mind making this a SkBitmap::Config? 
Whoever is calling this would just have to make sure to call your conversion
method before using this.

[vivekg, 2014/02/13 19:02:32]

Wouldn't it be more convenient to use Bitmap.Config (and more closer to being
implementation agnostic of skia) as is currently done? In doing the prior
conversion to skia config, the caller must be exposed to BitmapHelper thereby
exposing internal details. IMHO, we can live with the conversion being done
internally for providing ease-of-use API to the caller. WDYT?

[powei, 2014/02/13 19:30:20]

I guess my preference would be to limit the passing around of java objects in
native and that the JNI bridge methods would do all the conversion before
calling into strictly native code.

That said, this is just a preference, so I'm ok with keeping it as is if you
feel strongly about it.

       const base::Callback<void(bool, const SkBitmap&)>& result_callback)
       OVERRIDE;
   virtual float GetDpiScale() const OVERRIDE;