API to Convert Java Bitmap Config to SkBitmap::Config

content/browser/android/content_view_core_impl.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 #define CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_
 
 #include <vector>
 
 #include "base/android/jni_android.h"
@@ skipping 42 matching lines @@
   virtual WebContents* GetWebContents() const OVERRIDE;
   virtual ui::ViewAndroid* GetViewAndroid() const OVERRIDE;
   virtual ui::WindowAndroid* GetWindowAndroid() const OVERRIDE;
   virtual scoped_refptr<cc::Layer> GetLayer() const OVERRIDE;
   virtual void LoadUrl(NavigationController::LoadURLParams& params) OVERRIDE;
   virtual jint GetCurrentRenderProcessId(JNIEnv* env, jobject obj) OVERRIDE;
   virtual void ShowPastePopup(int x, int y) OVERRIDE;
   virtual void GetScaledContentBitmap(
       float scale,
       gfx::Size* out_size,
+      jobject bitmap_config,

[powei, 2014/02/13 18:30:11]

Thanks for the hard work.  Would you mind making this a SkBitmap::Config? 
Whoever is calling this would just have to make sure to call your conversion
method before using this.

[vivekg, 2014/02/13 19:02:32]

Wouldn't it be more convenient to use Bitmap.Config (and more closer to being
implementation agnostic of skia) as is currently done? In doing the prior
conversion to skia config, the caller must be exposed to BitmapHelper thereby
exposing internal details. IMHO, we can live with the conversion being done
internally for providing ease-of-use API to the caller. WDYT?

[powei, 2014/02/13 19:30:20]

I guess my preference would be to limit the passing around of java objects in
native and that the JNI bridge methods would do all the conversion before
calling into strictly native code.

That said, this is just a preference, so I'm ok with keeping it as is if you
feel strongly about it.

       const base::Callback<void(bool, const SkBitmap&)>& result_callback)
       OVERRIDE;
   virtual float GetDpiScale() const OVERRIDE;
   virtual void RequestContentClipping(const gfx::Rect& clipping,
                                       const gfx::Size& content_size) OVERRIDE;
   virtual void PauseVideo() OVERRIDE;
   virtual void ResumeVideo() OVERRIDE;
   virtual void PauseOrResumeGeolocation(bool should_pause) OVERRIDE;
 
   // --------------------------------------------------------------------------
@@ skipping 336 matching lines @@
   GestureEventPacket pending_gesture_packet_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentViewCoreImpl);
 };
 
 bool RegisterContentViewCore(JNIEnv* env);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ANDROID_CONTENT_VIEW_CORE_IMPL_H_