Chromium Code Reviews
Help | Chromium Project | Sign in
(1120)

Issue 15703018: Improved Quickoffice editing about:flag. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 2 weeks ago by dusk
Modified:
10 months, 1 week ago
CC:
chromium-reviews_chromium.org, arv+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Improved Quickoffice editing about:flag.

We were sniffing extension name from an alternate manifest to
drive experimental behaviour. This is apparant to the user and
unnecessary. Now we use the alternate manifest to inject experimental
feature capability into the background page that the extension
can query and use.

Change-Id: I6326d64b97723d0f102269cea02e5c9110e6fe1d

BUG=237052
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206363

Patch Set 1 #

Patch Set 2 : Correcting manifest files for inbuilt extension. #

Total comments: 2

Messages

Total messages: 8
dusk
Improved solution for QO experimental feature enabling.
10 months, 2 weeks ago #1
Dmitry Polukhin
https://codereview.chromium.org/15703018/diff/4001/chrome/browser/resources/quick_office/manifest.json File chrome/browser/resources/quick_office/manifest.json (right): https://codereview.chromium.org/15703018/diff/4001/chrome/browser/resources/quick_office/manifest.json#newcode4 chrome/browser/resources/quick_office/manifest.json:4: "scripts": [ Does this change require new js/html/nexe? If ...
10 months, 2 weeks ago #2
Dmitry Polukhin
LGTM As we discussed it offline this change should not break existing document viewer.
10 months, 2 weeks ago #3
James Hawkins
LGTM
10 months, 1 week ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dskelton@chromium.org/15703018/4001
10 months, 1 week ago #5
I haz the power (commit-bot)
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=50053
10 months, 1 week ago #6
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dskelton@chromium.org/15703018/4001
10 months, 1 week ago #7
I haz the power (commit-bot)
10 months, 1 week ago #8
Message was sent while issue was closed.
Change committed as 206363
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6