Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1569973002: Merge to XFA: Disentangle fpdfsave_embeddertest's FPDF_FILEWRITE. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Disentangle fpdfsave_embeddertest's FPDF_FILEWRITE. Original Review URL: https://codereview.chromium.org/1561303002 . (cherry picked from commit 5dc13d7858f9caf58b0e12f38823300a739302e2) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0aec19b09e48097df6096802f70daeb53d348c79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -42 lines) Patch
M fpdfsdk/src/fpdfedit_embeddertest.cpp View 1 chunk +42 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfsave_embeddertest.cpp View 1 chunk +21 lines, -41 lines 0 comments Download
M testing/test_support.h View 2 chunks +16 lines, -0 lines 0 comments Download
M testing/test_support.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR
4 years, 11 months ago (2016-01-07 20:16:37 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as 0aec19b09e48097df6096802f70daeb53d348c79 (presubmit successful).
4 years, 11 months ago (2016-01-07 20:22:47 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-07 21:31:00 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698