Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1561303002: Disentangle fpdfsave_embeddertest's FPDF_FILEWRITE, use gmock matchers. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disentangle fpdfsave_embeddertest's FPDF_FILEWRITE, use gmock matchers. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5dc13d7858f9caf58b0e12f38823300a739302e2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Regex out creation date, IDs. #

Patch Set 3 : Stray file. #

Patch Set 4 : Blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -42 lines) Patch
M fpdfsdk/src/fpdfedit_embeddertest.cpp View 1 1 chunk +42 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfsave_embeddertest.cpp View 1 chunk +21 lines, -41 lines 0 comments Download
M testing/test_support.h View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download
M testing/test_support.cpp View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Lei, for review.
4 years, 11 months ago (2016-01-06 21:38:47 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1561303002/diff/1/testing/test_support.h File testing/test_support.h (right): https://codereview.chromium.org/1561303002/diff/1/testing/test_support.h#newcode68 testing/test_support.h:68: TestSaver(); blank line after
4 years, 11 months ago (2016-01-07 00:43:59 UTC) #3
Tom Sepez
Committed patchset #4 (id:60001) manually as 5dc13d7858f9caf58b0e12f38823300a739302e2 (presubmit successful).
4 years, 11 months ago (2016-01-07 20:14:52 UTC) #5
Tom Sepez
4 years, 11 months ago (2016-01-07 20:16:24 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1561303002/diff/1/testing/test_support.h
File testing/test_support.h (right):

https://codereview.chromium.org/1561303002/diff/1/testing/test_support.h#newc...
testing/test_support.h:68: TestSaver();
On 2016/01/07 00:43:59, Lei Zhang wrote:
> blank line after

Done.

Powered by Google App Engine
This is Rietveld 408576698