Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 156993002: Use correct FFT scaling for WebAudio AnalyserNode (Closed)

Created:
6 years, 10 months ago by Raymond Toy (Google)
Modified:
6 years, 10 months ago
CC:
blink-reviews, Raymond Toy
Visibility:
Public.

Description

Use correct FFT scaling for WebAudio AnalyserNode Currently, for a fixed sine-wave input, the peak FFT amplitude changes depending on the selected FFT size. This is incorrect; the FFT amplitude should not appreciably change when the FFT size changes. Layout test added to verify the FFT result stays approximately constant, independent of the FFT size used. When this test is run using an older version of Chrome, the peak varies from about -44 dB (FFT size 32) to -7 dB (FFT size 2048). With this CL, the peak is about -7 dB. (It's not 0 dB because of the Blackman window that is applied.) Note: this change may break existing applications that depended on this strange scaling effect. BUG=341536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166687

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -1 line) Patch
A LayoutTests/webaudio/realtimeanalyser-fft-scaling.html View 1 1 chunk +124 lines, -0 lines 0 comments Download
A LayoutTests/webaudio/realtimeanalyser-fft-scaling-expected.txt View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/modules/webaudio/RealtimeAnalyser.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Raymond Toy (Google)
PTAL.
6 years, 10 months ago (2014-02-06 21:44:27 UTC) #1
Ken Russell (switch to Gerrit)
Wow. Nice test for a one-line change. LGTM
6 years, 10 months ago (2014-02-07 02:44:07 UTC) #2
Ken Russell (switch to Gerrit)
Note, the BUG= line in the CL description should be the last thing, I think.
6 years, 10 months ago (2014-02-07 02:44:51 UTC) #3
Raymond Toy (Google)
On 2014/02/07 02:44:51, Ken Russell wrote: > Note, the BUG= line in the CL description ...
6 years, 10 months ago (2014-02-07 05:58:49 UTC) #4
Raymond Toy (Google)
The CQ bit was checked by rtoy@google.com
6 years, 10 months ago (2014-02-07 05:58:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/156993002/30001
6 years, 10 months ago (2014-02-07 05:59:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-07 07:33:25 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-02-07 07:33:26 UTC) #8
Raymond Toy (Google)
The CQ bit was checked by rtoy@google.com
6 years, 10 months ago (2014-02-07 07:37:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/156993002/30001
6 years, 10 months ago (2014-02-07 07:37:40 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 07:38:02 UTC) #11
Message was sent while issue was closed.
Change committed as 166687

Powered by Google App Engine
This is Rietveld 408576698