Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1306)

Unified Diff: chrome/browser/devtools/devtools_network_protocol_handler.cc

Issue 1569893003: Add "Request app banner" context menu in DevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated dfalcantara's comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_network_protocol_handler.cc
diff --git a/chrome/browser/devtools/devtools_network_protocol_handler.cc b/chrome/browser/devtools/devtools_network_protocol_handler.cc
index 2b7ca3c011d84fe8d26506e70bad0cd8c339e364..72312e209802ac2e82f9d51274db083cd721fc1a 100644
--- a/chrome/browser/devtools/devtools_network_protocol_handler.cc
+++ b/chrome/browser/devtools/devtools_network_protocol_handler.cc
@@ -22,13 +22,9 @@ DevToolsNetworkProtocolHandler::~DevToolsNetworkProtocolHandler() {
base::DictionaryValue* DevToolsNetworkProtocolHandler::HandleCommand(
content::DevToolsAgentHost* agent_host,
- base::DictionaryValue* command_dict) {
- int id = 0;
- std::string method;
- base::DictionaryValue* params = nullptr;
- if (!DevToolsProtocol::ParseCommand(command_dict, &id, &method, &params))
- return nullptr;
-
+ int id,
+ const std::string& method,
+ base::DictionaryValue* params) {
namespace network = ::chrome::devtools::Network;
if (method == network::emulateNetworkConditions::kName)

Powered by Google App Engine
This is Rietveld 408576698