Add "Request app banner" context menu in DevTools

chrome/browser/banners/app_banner_debug_log.cc

Index: chrome/browser/banners/app_banner_debug_log.cc
diff --git a/chrome/browser/banners/app_banner_debug_log.cc b/chrome/browser/banners/app_banner_debug_log.cc
index e1b06f91b5a42ee79b917a32db5ae27d3406a3d8..99e26f7be00e6862030316bac2a39276d153fc16 100644
--- a/chrome/browser/banners/app_banner_debug_log.cc
+++ b/chrome/browser/banners/app_banner_debug_log.cc
@@ -4,8 +4,6 @@
 
 #include "chrome/browser/banners/app_banner_debug_log.h"
 
-#include "base/command_line.h"
-#include "chrome/common/chrome_switches.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 
@@ -33,6 +31,7 @@ const char kManifestMissingNameOrShortName[] =
 const char kManifestMissingSuitableIcon[] =
     "manifest does not contain a suitable icon - PNG format of at least "
     "144x144px is required, and the sizes attribute must be set";
+const char kNotLoadedInMainFrame[] = "page not loaded in the main frame";
 const char kNotServedFromSecureOrigin[] =
     "page not served from a secure origin";
 // The leading space is intentional as another string is prepended.
@@ -44,19 +43,19 @@ const char kIgnoredIdsDoNotMatch[] =
     "manifest, but they do not match";
 
 void OutputDeveloperNotShownMessage(content::WebContents* web_contents,
-                                    const std::string& message) {
-  OutputDeveloperDebugMessage(web_contents, "not shown: " + message);
+                                    const std::string& message,
+                                    bool is_debug_mode) {
+  OutputDeveloperDebugMessage(web_contents, "not shown: " + message,
+                              is_debug_mode);
 }
 
 void OutputDeveloperDebugMessage(content::WebContents* web_contents,
-                                 const std::string& message) {
-  std::string log_message = "App banner " + message;
-  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kBypassAppBannerEngagementChecks) &&
-      web_contents) {
-    web_contents->GetMainFrame()->AddMessageToConsole(
-        content::CONSOLE_MESSAGE_LEVEL_DEBUG, log_message);
-  }
+                                 const std::string& message,
+                                 bool is_debug_mode) {
+  if (!is_debug_mode || !web_contents)

[pfeldman, 2016/01/20 04:30:17]

Why do we need to plumb is_debug_mode all the way to here? Can we send it to the
console unconditionally?

[dominickn, 2016/01/20 05:37:25]

Currently, the logging functions are *always* called, but output is only sent to
the console if the bypass-app-banner-engagement-checks flag is present. When the
flag is off, then nothing should be sent to the console to avoid spamming it.

Sending output to the console unconditionally would be very noisy: every site
would trigger at least one message on Android and ChromeOS, where this feature
is 100% rolled out. Most of the messages would be "not a secure origin", or "no
service worker", or "no web manifest".

The alternative is to guard every call to this logging with if (is_debug_mode),
but I think it's cleaner having one if check in here (at the cost of plumbing
the boolean). Previously, it would check the command line switch in here; this
CL combines the command line switch into is_debug_mode.

+    return;
+  web_contents->GetMainFrame()->AddMessageToConsole(
+      content::CONSOLE_MESSAGE_LEVEL_DEBUG, "App banner " + message);
 }
 
 }  // namespace banners