Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1569663002: Invalidate IPWL_FocusHandler and IPWL_Provider on destruction. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Invalidate IPWL_FocusHandler and IPWL_Provider on destruction. BUG=572871 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1564773003 . (cherry picked from commit dcac57bc8b64fdc870d79d11a498ae7021cf8ae7) Committed: https://pdfium.googlesource.com/pdfium/+/ab5537db5f9f52f19dea03850512fd6b10bdcd84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -120 lines) Patch
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
A + testing/resources/bug_572871.in View 1 chunk +21 lines, -51 lines 0 comments Download
A + testing/resources/bug_572871.pdf View 1 chunk +35 lines, -67 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Lei Zhang
TBR, clean merge.
4 years, 11 months ago (2016-01-06 22:57:45 UTC) #1
Lei Zhang
4 years, 11 months ago (2016-01-06 22:58:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab5537db5f9f52f19dea03850512fd6b10bdcd84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698