Chromium Code Reviews

Issue 1564773003: Invalidate IPWL_FocusHandler and IPWL_Provider on destruction. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Invalidate IPWL_FocusHandler and IPWL_Provider on destruction. BUG=572871 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/dcac57bc8b64fdc870d79d11a498ae7021cf8ae7

Patch Set 1 #

Total comments: 8

Patch Set 2 : nits #

Patch Set 3 : with test #

Patch Set 4 : fix copy pasta #

Unified diffs Side-by-side diffs Stats (+79 lines, -120 lines)
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 chunk +2 lines, -0 lines 0 comments
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 1 chunk +2 lines, -0 lines 0 comments
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 1 chunk +2 lines, -1 line 0 comments
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 chunk +2 lines, -0 lines 0 comments
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +5 lines, -1 line 0 comments
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 1 chunk +10 lines, -0 lines 0 comments
A + testing/resources/bug_572871.in View 1 chunk +21 lines, -51 lines 0 comments
A + testing/resources/bug_572871.pdf View 1 chunk +35 lines, -67 lines 0 comments

Messages

Total messages: 7 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-06 19:30:58 UTC) #2
Tom Sepez
Test? https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_ComboBox.cpp File fpdfsdk/src/formfiller/FFL_ComboBox.cpp (right): https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_ComboBox.cpp#newcode24 fpdfsdk/src/formfiller/FFL_ComboBox.cpp:24: for (auto& it : m_Maps) { nit: const ...
4 years, 11 months ago (2016-01-06 19:58:26 UTC) #3
Lei Zhang
https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_ComboBox.cpp File fpdfsdk/src/formfiller/FFL_ComboBox.cpp (right): https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_ComboBox.cpp#newcode24 fpdfsdk/src/formfiller/FFL_ComboBox.cpp:24: for (auto& it : m_Maps) { On 2016/01/06 19:58:25, ...
4 years, 11 months ago (2016-01-06 22:08:38 UTC) #4
Tom Sepez
lgtm
4 years, 11 months ago (2016-01-06 22:19:08 UTC) #5
Lei Zhang
4 years, 11 months ago (2016-01-06 22:42:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
dcac57bc8b64fdc870d79d11a498ae7021cf8ae7 (presubmit successful).

Powered by Google App Engine