thestig@chromium.org changed reviewers: + tsepez@chromium.org
Test? https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... File fpdfsdk/src/formfiller/FFL_ComboBox.cpp (right): https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... fpdfsdk/src/formfiller/FFL_ComboBox.cpp:24: for (auto& it : m_Maps) { nit: const auto? https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... fpdfsdk/src/formfiller/FFL_ComboBox.cpp:25: CPWL_Wnd* pWnd = it.second; nit: local not needed. https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... File fpdfsdk/src/formfiller/FFL_FormFiller.cpp (right): https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... fpdfsdk/src/formfiller/FFL_FormFiller.cpp:27: for (auto& it : m_Maps) { nit: const auto& here too, we're not modifying the map itself in the loop. https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... File fpdfsdk/src/formfiller/FFL_TextField.cpp (right): https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... fpdfsdk/src/formfiller/FFL_TextField.cpp:20: CPWL_Wnd* pWnd = it.second; nitto
https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... File fpdfsdk/src/formfiller/FFL_ComboBox.cpp (right): https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... fpdfsdk/src/formfiller/FFL_ComboBox.cpp:24: for (auto& it : m_Maps) { On 2016/01/06 19:58:25, Tom Sepez wrote: > nit: const auto? Done. https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... fpdfsdk/src/formfiller/FFL_ComboBox.cpp:25: CPWL_Wnd* pWnd = it.second; On 2016/01/06 19:58:26, Tom Sepez wrote: > nit: local not needed. Done. https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... File fpdfsdk/src/formfiller/FFL_FormFiller.cpp (right): https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... fpdfsdk/src/formfiller/FFL_FormFiller.cpp:27: for (auto& it : m_Maps) { On 2016/01/06 19:58:26, Tom Sepez wrote: > nit: const auto& here too, we're not modifying the map itself in the loop. Done. https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... File fpdfsdk/src/formfiller/FFL_TextField.cpp (right): https://codereview.chromium.org/1564773003/diff/1/fpdfsdk/src/formfiller/FFL_... fpdfsdk/src/formfiller/FFL_TextField.cpp:20: CPWL_Wnd* pWnd = it.second; On 2016/01/06 19:58:26, Tom Sepez wrote: > nitto Done.
lgtm
Description was changed from ========== Invalidate IPWL_FocusHandler and IPWL_Provider on destruction. BUG=572871 ========== to ========== Invalidate IPWL_FocusHandler and IPWL_Provider on destruction. BUG=572871 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/dcac57bc8b64fdc870d79d11a498ae7021cf... ==========
Committed patchset #4 (id:60001) manually as dcac57bc8b64fdc870d79d11a498ae7021cf8ae7 (presubmit successful).
Chromium Code Reviews
