Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1569623002: Fix-up some code relating to SRI double-requesting scripts (Closed)

Created:
4 years, 11 months ago by jww
Modified:
4 years, 11 months ago
Reviewers:
Yoav Weiss, sof
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, sof, eae+blinkwatch, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, rwlbuis, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix-up some code relating to SRI double-requesting scripts I failed to upload a few fixes to https://codereview.chromium.org/1561903002/ before committing, and this is the follow-up to fix those issues. Adds a couple of minor nits and cleanup, as well as an extra test for stylesheets. BUG=573269 TBR=yoav@yoav.ws,sigbjornf@opera.com Committed: https://crrev.com/47aef016c4cac1c0e238c7785d4641f6e2454807 Cr-Commit-Position: refs/heads/master@{#368010}

Patch Set 1 #

Total comments: 2

Patch Set 2 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -105 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-document-initiator.html View 1 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator.html View 1 3 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator-from-console.html View 1 2 chunks +2 lines, -10 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/style-with-integrity-frame.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests.html View 1 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests-for-script.html View 1 1 chunk +1 line, -12 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests-for-script-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests-for-stylesheet.html View 1 2 chunks +3 lines, -14 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests-for-stylesheet-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
sof
https://codereview.chromium.org/1569623002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests.html File third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests.html (right): https://codereview.chromium.org/1569623002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests.html#newcode19 third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests.html:19: var requests = InspectorTest.findRequestsByURLPattern(/call-success.js/); This is not the only ...
4 years, 11 months ago (2016-01-06 21:17:01 UTC) #1
Yoav Weiss
LGTM from my end
4 years, 11 months ago (2016-01-06 22:22:19 UTC) #2
jww
On 2016/01/06 22:22:19, Yoav Weiss wrote: > LGTM from my end sof: I modified several ...
4 years, 11 months ago (2016-01-06 23:36:00 UTC) #3
jww
https://codereview.chromium.org/1569623002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests.html File third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests.html (right): https://codereview.chromium.org/1569623002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests.html#newcode19 third_party/WebKit/LayoutTests/http/tests/inspector/network/subresource-integrity-number-of-requests.html:19: var requests = InspectorTest.findRequestsByURLPattern(/call-success.js/); On 2016/01/06 21:17:01, sof wrote: ...
4 years, 11 months ago (2016-01-06 23:37:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569623002/20001
4 years, 11 months ago (2016-01-06 23:37:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/155922)
4 years, 11 months ago (2016-01-07 01:54:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569623002/20001
4 years, 11 months ago (2016-01-07 02:28:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-07 03:57:05 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/47aef016c4cac1c0e238c7785d4641f6e2454807 Cr-Commit-Position: refs/heads/master@{#368010}
4 years, 11 months ago (2016-01-07 03:58:13 UTC) #14
sof
4 years, 11 months ago (2016-01-07 06:26:58 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698