Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator.html

Issue 1569623002: Fix-up some code relating to SRI double-requesting scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: More fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator.html
index 04cfa9897eab5558dbf0c61e32aa2311a4472d44..3adb5917ba5e25270e45b736960cb1e3c6833f5e 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator.html
@@ -27,15 +27,6 @@ var test = function()
{
step2();
- function findRequestByURL(url)
- {
- var requests = InspectorTest.networkRequests();
- for (var i = 0; i < requests.length; ++i) {
- if (url.test(requests[i].url))
- return requests[i];
- }
- }
-
/*function step1()
{
InspectorTest.networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, onRequest);
@@ -51,7 +42,7 @@ var test = function()
function step2()
{
- //if (!findRequestByURL(/size=300/))
+ //if (InspectorTest.findRequestsByURLPattern(/size=300/).length === 0)
// return;
InspectorTest.addConsoleSniffer(step3);
@@ -62,11 +53,12 @@ var test = function()
{
function dumpInitiator(url)
{
- var request = findRequestByURL(new RegExp(url.replace(".", "\\.")));
- if (!request) {
+ var matching_requests = InspectorTest.findRequestsByURLPattern(new RegExp(url.replace(".", "\\.")));
+ if (matching_requests.length === 0) {
InspectorTest.addResult(url + " NOT FOUND");
return;
}
+ var request = matching_requests[0];
var initiator = request.initiator();
InspectorTest.addResult(request.url + ": " + initiator.type);
if (initiator.url)

Powered by Google App Engine
This is Rietveld 408576698