Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1569553007: Remove "unused" parameter from filterInputGPU (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 11 months ago
Reviewers:
senorblanco, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
robertphillips
WDYT Stephen? The existence of 'relaxSizeConstraint' on filterInputGPU surprised me when investigating some of filterImageGPU's ...
4 years, 11 months ago (2016-01-08 15:01:12 UTC) #4
Stephen White
On 2016/01/08 15:01:12, robertphillips wrote: > WDYT Stephen? The existence of 'relaxSizeConstraint' on filterInputGPU surprised ...
4 years, 11 months ago (2016-01-08 16:27:13 UTC) #6
reed1
True. However, it will be a while before I think we'll get around to fully ...
4 years, 11 months ago (2016-01-08 16:56:44 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569553007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569553007/1
4 years, 11 months ago (2016-01-08 17:09:55 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-08 17:25:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1569553007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1569553007/1
4 years, 11 months ago (2016-01-08 17:27:43 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 17:28:26 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2c3176c18fcb0ef1594ca9dfbcabcb5e86086301

Powered by Google App Engine
This is Rietveld 408576698