Issue 1569483004: Merge to XFA: Return const-ref object in a few CPWL_Wnd getters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1569483004: Merge to XFA: Return const-ref object in a few CPWL_Wnd getters. (Closed)

Created:
4 years, 11 months ago by Lei Zhang

Modified:
4 years, 11 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Return const-ref object in a few CPWL_Wnd getters. Also remove a bunch of dead code. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1565803003 . (cherry picked from commit cbed99098ad4cdc3f9f260cc1e8521f67c12d35d) Committed: https://pdfium.googlesource.com/pdfium/+/7457e38fae636ce3d0cda2c7fd2e100975440222

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -56 lines)			Patch
M	fpdfsdk/include/pdfwindow/PWL_Utils.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	fpdfsdk/include/pdfwindow/PWL_Wnd.h	View	3 chunks	+3 lines, -10 lines	0 comments	Download
M	fpdfsdk/src/pdfwindow/PWL_Utils.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	fpdfsdk/src/pdfwindow/PWL_Wnd.cpp	View	9 chunks	+8 lines, -44 lines	0 comments	Download

Total messages: 3 (1 generated)

Lei Zhang

4 years, 11 months ago (2016-01-07 07:00:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7457e38fae636ce3d0cda2c7fd2e100975440222 (presubmit successful).