Return const-ref object in a few CPWL_Wnd getters.

Return const-ref object in a few CPWL_Wnd getters.

Also remove a bunch of dead code.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/cbed99098ad4cdc3f9f260cc1e8521f67c12d35d

[Lei Zhang, 2016-01-06 22:08:58]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-01-06 22:14:18]

We're sure about object lifetimes?

[Lei Zhang, 2016-01-06 22:54:01]

Description was changed from

==========
Return const-ref object in a few CPWL_Wnd getters.
==========

to

==========
Return const-ref object in a few CPWL_Wnd getters.

Also remove a bunch of dead code.
==========

[Lei Zhang, 2016-01-06 22:55:22]

On 2016/01/06 22:14:18, Tom Sepez wrote:
> We're sure about object lifetimes?

Yes. And trying to return a temporary by reference generates compiler warnings.
As usual, there is dead code, so I removed some.

[Tom Sepez, 2016-01-06 22:56:45]

lgtm

[Lei Zhang, 2016-01-06 22:58:53]

Description was changed from

==========
Return const-ref object in a few CPWL_Wnd getters.

Also remove a bunch of dead code.
==========

to

==========
Return const-ref object in a few CPWL_Wnd getters.

Also remove a bunch of dead code.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/cbed99098ad4cdc3f9f260cc1e8521f67c12...
==========

[Lei Zhang, 2016-01-06 22:58:54]

Committed patchset #3 (id:40001) manually as
cbed99098ad4cdc3f9f260cc1e8521f67c12d35d (presubmit successful).