Issue 1569213003: Eliminate phase parameter in constructors

Issue 1569213003: Eliminate phase parameter in constructors (Closed)

Created:
4 years, 11 months ago by hausner

Modified:
4 years, 11 months ago

Reviewers:
rmacnak, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Eliminate phase parameter in constructors Super initializer calls get implicitly moved to the end of the initializer list, so we don't need the two-phase constructor protocol anymore. Ryan, can you please look at the mirror changes and check wether I've missed something? BUG= R=asiva@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4ffdcb76dfac137ec802616f0e9f8a90eacd7925

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -273 lines)			Patch
M	runtime/lib/mirrors.cc	View	1	3 chunks	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View		6 chunks	+7 lines, -10 lines	0 comments	Download
M	runtime/vm/dart_entry.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/dart_entry_test.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	2 chunks	+4 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	runtime/vm/method_recognizer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View		2 chunks	+3 lines, -11 lines	0 comments	Download
M	runtime/vm/parser.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View		23 chunks	+25 lines, -217 lines	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 8 (3 generated)

rmacnak

LGTM! Nice code shrink too: dart2js precompiled ARM 25428888 -> 24983526 (-1.75%)

4 years, 11 months ago (2016-01-08 22:22:21 UTC) #4

hausner

Thanks. There was also a 1.5% reduction in code size with the CL the eliminates ...

4 years, 11 months ago (2016-01-08 22:41:53 UTC) #5

hausner

4 years, 11 months ago (2016-01-08 23:41:57 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4ffdcb76dfac137ec802616f0e9f8a90eacd7925 (presubmit successful).