Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 1569213003: Eliminate phase parameter in constructors (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/method_recognizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc
index 3c3725c8fb45d9b5714eef424ca679a5a111497b..7ea528a4a6fa010c8a8769d55d404071ad20934b 100644
--- a/runtime/vm/flow_graph_type_propagator.cc
+++ b/runtime/vm/flow_graph_type_propagator.cc
@@ -695,7 +695,7 @@ CompileType ParameterInstr::ComputeType() const {
// verifying the run time type of the passed-in parameter and this check would
// always be wrongly eliminated.
// However there are parameters that are known to match their declared type:
- // for example receiver and construction phase.
+ // for example receiver.
GraphEntryInstr* graph_entry = block_->AsGraphEntry();
// Parameters at catch blocks and OSR entries have type dynamic.
//
@@ -727,11 +727,6 @@ CompileType ParameterInstr::ComputeType() const {
LocalScope* scope = graph_entry->parsed_function().node_sequence()->scope();
const AbstractType& type = scope->VariableAt(index())->type();
- // Parameter is the constructor phase.
- if ((index() == 1) && function.IsGenerativeConstructor()) {
- return CompileType::FromAbstractType(type, CompileType::kNonNullable);
- }
-
// Parameter is the receiver.
if ((index() == 0) &&
(function.IsDynamicFunction() || function.IsGenerativeConstructor())) {
« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/method_recognizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698