MacViews: Style BUTTON_STYLE buttons using the "modern" UI

MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Updates views_examples so that all buttons in the example page can be
toggled "default" (currently only the first button can be, which isn't
STYLE_BUTTON).

Screenshots: http://crbug.com/543686#c5 #c6

BUG=543686
Committed: https://crrev.com/b43f95769ea64a0b000cf524a9d75df1f73e40ed
Cr-Commit-Position: refs/heads/master@{#386322}

[tapted, 2016-01-08 04:16:35]

Description was changed from

==========
MacViews PoC: Mac Style buttons drawn by Skia

DO NOT COMMIT (until the font size hack is fixed)

Prelim compile fixes


They look great!

BUG=
==========

to

==========
MacViews PoC: Mac Style buttons drawn by Skia

Changes DialogButtonBorderMac to draw Cocoa-style buttons, and
tweaks views::LabelButton to pick up some Cocoaish behaviours.

BUG=543686
==========

[tapted, 2016-01-08 04:17:09]

Description was changed from

==========
MacViews PoC: Mac Style buttons drawn by Skia

Changes DialogButtonBorderMac to draw Cocoa-style buttons, and
tweaks views::LabelButton to pick up some Cocoaish behaviours.

BUG=543686
==========

to

==========
MacViews PoC: Mac Style buttons drawn by Skia

Changes DialogButtonBorderMac to draw Cocoa-style buttons, and
tweaks views::LabelButton to pick up some Cocoaish behaviours.

Sceenshots: http://crbug.com/543686#c3

BUG=543686
==========

[tapted, 2016-04-04 08:09:41]

Patchset #1 (id:1) has been deleted

[tapted, 2016-04-04 08:09:52]

Patchset #1 (id:20001) has been deleted

[tapted, 2016-04-05 10:56:24]

Patchset #2 (id:60001) has been deleted

[tapted, 2016-04-05 10:57:00]

Patchset #3 (id:100001) has been deleted

[tapted, 2016-04-05 10:57:12]

Patchset #3 (id:120001) has been deleted

[tapted, 2016-04-05 10:57:24]

Patchset #3 (id:140001) has been deleted

[tapted, 2016-04-05 10:58:02]

Patchset #3 (id:160001) has been deleted

[tapted, 2016-04-05 10:58:32]

Patchset #5 (id:220001) has been deleted

[tapted, 2016-04-05 11:03:20]

Patchset #6 (id:260001) has been deleted

[tapted, 2016-04-05 12:54:39]

Patchset #7 (id:300001) has been deleted

[tapted, 2016-04-05 12:54:51]

Patchset #7 (id:320001) has been deleted

[tapted, 2016-04-05 13:14:54]

Description was changed from

==========
MacViews PoC: Mac Style buttons drawn by Skia

Changes DialogButtonBorderMac to draw Cocoa-style buttons, and
tweaks views::LabelButton to pick up some Cocoaish behaviours.

Sceenshots: http://crbug.com/543686#c3

BUG=543686
==========

to

==========
MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this 
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Sceenshots: http://crbug.com/543686#c5 #c6

BUG=543686
==========

[tapted, 2016-04-05 13:14:55]

tapted@chromium.org changed reviewers:
+ ellyjones@chromium.org

[tapted, 2016-04-05 13:15:06]

Description was changed from

==========
MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this 
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Sceenshots: http://crbug.com/543686#c5 #c6

BUG=543686
==========

to

==========
MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this 
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Screenshots: http://crbug.com/543686#c5 #c6

BUG=543686
==========

[tapted, 2016-04-05 13:15:16]

Patchset #9 (id:380001) has been deleted

[tapted, 2016-04-05 13:19:18]

Hi Elly, could you please do a review pass before I send on to sky?

One question is the corner radius. I think the mocks we got were hi-dpi so the
corner radius looks bigger there. Taking the mocks and scaling down gives
something closer to 2.

[Elly Fong-Jones, 2016-04-05 16:43:25]

lgtm

https://codereview.chromium.org/1569113002/diff/400001/ui/native_theme/native...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/1569113002/diff/400001/ui/native_theme/native...
ui/native_theme/native_theme_mac.mm:46: struct EnumArray {
Oh, this is a very clever idea, and I like it.

https://codereview.chromium.org/1569113002/diff/400001/ui/native_theme/native...
ui/native_theme/native_theme_mac.mm:294: start_colors[BackgroundType::NORMAL] =
SK_ColorWHITE;
Why are normal buttons SK_ColorWHITE instead of gfx::kMaterialBlue300?

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
File ui/views/controls/button/custom_button.cc (right):

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
ui/views/controls/button/custom_button.cc:108: if (!strcmp(classname,
Checkbox::kViewClassName) ||
This seems a little weird... if anyone adds another "LabelButton-like" later,
they'll have to know about this code to update it. I can't really think of
anything better to do but I'm not that thrilled with this code.

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
File ui/views/controls/button/label_button.h (right):

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
ui/views/controls/button/label_button.h:170: void HighlightStateChanged();
This function's comment is a little bit vague. It should probably describe what
the state being updated is, at least.

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
File ui/views/controls/button/label_button_unittest.cc (right):

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
ui/views/controls/button/label_button_unittest.cc:83: // For styled buttons
only, platforms other than Desktop Linux ignoree the
ignore

[tapted, 2016-04-06 09:26:12]

Patchset #10 (id:420001) has been deleted

[tapted, 2016-04-06 09:27:55]

Patchset #10 (id:430001) has been deleted

[tapted, 2016-04-06 11:47:53]

Patchset #10 (id:450001) has been deleted

[tapted, 2016-04-06 12:03:20]

Description was changed from

==========
MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this 
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Screenshots: http://crbug.com/543686#c5 #c6

BUG=543686
==========

to

==========
MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this 
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Updates views_examples so that all buttons in the example page can be
toggled "default" (currently only the first button can be, which isn't
STYLE_BUTTON).

Screenshots: http://crbug.com/543686#c5 #c6

BUG=543686
==========

[tapted, 2016-04-06 12:03:20]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2016-04-06 12:08:33]

+sky - please take a look for OWNERS

(note for the added tests, I ran a CL -- crrev.com/1859353002 -- to ensure they
pass without the rest of the CL too. That is, this CL shouldn't be changing
things on platforms other than Mac).

https://codereview.chromium.org/1569113002/diff/400001/ui/native_theme/native...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/1569113002/diff/400001/ui/native_theme/native...
ui/native_theme/native_theme_mac.mm:46: struct EnumArray {
On 2016/04/05 16:43:25, Elly Jones wrote:
> Oh, this is a very clever idea, and I like it.

:) Although the obvious question is whether we make this a thing in src/base
somewhere - not sure whether 5 lines warrants that, but it might be a good
follow-up. I'll see what sky makes of it

https://codereview.chromium.org/1569113002/diff/400001/ui/native_theme/native...
ui/native_theme/native_theme_mac.mm:294: start_colors[BackgroundType::NORMAL] =
SK_ColorWHITE;
On 2016/04/05 16:43:25, Elly Jones wrote:
> Why are normal buttons SK_ColorWHITE instead of gfx::kMaterialBlue300?

This is from the mocks -- only the "primary" / default buttons are blue. Also
the mocks don't yet describe the behaviour when the window doesn't have focus.
In Cocoa, all the combobox arrows switch from a blue background to a white
background if the window isn't active.

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
File ui/views/controls/button/custom_button.cc (right):

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
ui/views/controls/button/custom_button.cc:108: if (!strcmp(classname,
Checkbox::kViewClassName) ||
On 2016/04/05 16:43:25, Elly Jones wrote:
> This seems a little weird... if anyone adds another "LabelButton-like" later,
> they'll have to know about this code to update it. I can't really think of
> anything better to do but I'm not that thrilled with this code.

Yeah I agree. However, this is the typical approach, and I put in in
custom_button.cc rather than label_button.cc so at least if one needs to be
updated, there's a better chance that someone will remember to update both.

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
File ui/views/controls/button/label_button.h (right):

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
ui/views/controls/button/label_button.h:170: void HighlightStateChanged();
On 2016/04/05 16:43:25, Elly Jones wrote:
> This function's comment is a little bit vague. It should probably describe
what
> the state being updated is, at least.

Done.

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
File ui/views/controls/button/label_button_unittest.cc (right):

https://codereview.chromium.org/1569113002/diff/400001/ui/views/controls/butt...
ui/views/controls/button/label_button_unittest.cc:83: // For styled buttons
only, platforms other than Desktop Linux ignoree the
On 2016/04/05 16:43:25, Elly Jones wrote:
> ignore

Done. (had to tweak styled_highlight_text_color_ for linux too)

[sky, 2016-04-07 17:16:32]

https://codereview.chromium.org/1569113002/diff/470001/ui/native_theme/native...
File ui/native_theme/native_theme_mac.h (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/native_theme/native...
ui/native_theme/native_theme_mac.h:22: enum class BackgroundType { DISABLED,
HIGHLIGHTED, NORMAL, PRESSED, COUNT };
BackgroundType is rather vague. These constants seem specific to Buttons.
ButtonBackgroundType?

https://codereview.chromium.org/1569113002/diff/470001/ui/native_theme/native...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/native_theme/native...
ui/native_theme/native_theme_mac.mm:284: typedef EnumArray<BackgroundType,
SkColor> ColorByState;
typedef->using

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
File ui/views/controls/button/custom_button.h (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/custom_button.h:38: static const LabelButton*
AsLabelButton(const views::View* view);
I am not a fan of using the view class name for RTTI. It's brittle. Is there
another way to accomplish what you need that doesn't involve using the class
name?

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/label_button.cc:162: bool bold =
PlatformStyle::kDefaultLabelButtonHasBoldFont && is_default_;
Seems like you can skip cached_bold_font_list_ entirely if
kDefaultLabelButtonHasBoldFont is false. Maybe make cached_bold_font_list_  a
scoped_ptr?

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/label_button.cc:468: colors[STATE_HOVERED] =
colors[STATE_PRESSED] = colors[STATE_NORMAL];
nit: a single assignment setting all to WHITE is more readable.

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/label_button.cc:554: void
LabelButton::HighlightStateChanged() {
This function is confusingly named as there is no 'highlight' state, and it's
invoked at random ties. I think a more specific name would be better, perhaps
ResetLabelEnabledColor().

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/label_button.cc:555: const SkColor color =
If you're going to use const (which is good), be consistent. You don't use it
for 'bool bold' in this file when you could as well.

https://codereview.chromium.org/1569113002/diff/470001/ui/views/style/mac/dia...
File ui/views/style/mac/dialog_button_border_mac.h (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/views/style/mac/dia...
ui/views/style/mac/dialog_button_border_mac.h:22: static bool ShowsDefault(const
CustomButton& button);
static function are after constructor/destructor.
ShouldRenderDefault?

https://codereview.chromium.org/1569113002/diff/470001/ui/views/style/platfor...
File ui/views/style/platform_style.h (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/views/style/platfor...
ui/views/style/platform_style.h:27: typedef SkColor
ButtonColorByState[Button::STATE_COUNT];
using?

[tapted, 2016-04-08 08:27:15]

Patchset #12 (id:510001) has been deleted

[tapted, 2016-04-08 08:35:33]

https://codereview.chromium.org/1569113002/diff/470001/ui/native_theme/native...
File ui/native_theme/native_theme_mac.h (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/native_theme/native...
ui/native_theme/native_theme_mac.h:22: enum class BackgroundType { DISABLED,
HIGHLIGHTED, NORMAL, PRESSED, COUNT };
On 2016/04/07 17:16:31, sky wrote:
> BackgroundType is rather vague. These constants seem specific to Buttons.
> ButtonBackgroundType?

Done.

https://codereview.chromium.org/1569113002/diff/470001/ui/native_theme/native...
File ui/native_theme/native_theme_mac.mm (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/native_theme/native...
ui/native_theme/native_theme_mac.mm:284: typedef EnumArray<BackgroundType,
SkColor> ColorByState;
On 2016/04/07 17:16:31, sky wrote:
> typedef->using

Done.

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
File ui/views/controls/button/custom_button.h (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/custom_button.h:38: static const LabelButton*
AsLabelButton(const views::View* view);
On 2016/04/07 17:16:31, sky wrote:
> I am not a fan of using the view class name for RTTI. It's brittle. Is there
> another way to accomplish what you need that doesn't involve using the class
> name?

There's not really any logic that depends on the RTTI - it's more just to be
defensive. So I've removed it in the latest CL. Currently this means that code
needs to be "careful" only to put the result of
PlatformStyle::CreateLabelButtonBorder onto a LabelButton.

We could make this agreement more formal by storing a LabelButton* data member
on LabelButtonBorder and ignoring (or DCHECKing) the |view| passed in via
Border::Paint into DialogButtonBorderMac

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/label_button.cc:162: bool bold =
PlatformStyle::kDefaultLabelButtonHasBoldFont && is_default_;
On 2016/04/07 17:16:31, sky wrote:
> Seems like you can skip cached_bold_font_list_ entirely if
> kDefaultLabelButtonHasBoldFont is false. Maybe make cached_bold_font_list_  a
> scoped_ptr?

gfx::FontList is itself just a scoped_refptr, and default-constructing a
gfx::FontList is cheap now that it just references `g_default_impl` in
font_list.cc. So a scoped_ptr might not add much. However, you're right that I'm
missing out on cases where it's fine to leave cached_bold_font_list_ untouched,
so I've fixed that.


(I guess an orthogonal question is whether the caching really adds much on any
platform, since it should be rare for a button to switch between
SetIsDefault(true/false)...)

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/label_button.cc:468: colors[STATE_HOVERED] =
colors[STATE_PRESSED] = colors[STATE_NORMAL];
On 2016/04/07 17:16:31, sky wrote:
> nit: a single assignment setting all to WHITE is more readable.

Done.

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/label_button.cc:554: void
LabelButton::HighlightStateChanged() {
On 2016/04/07 17:16:31, sky wrote:
> This function is confusingly named as there is no 'highlight' state, and it's
> invoked at random ties. I think a more specific name would be better, perhaps
> ResetLabelEnabledColor().

Done.

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/label_button.cc:555: const SkColor color =
On 2016/04/07 17:16:31, sky wrote:
> If you're going to use const (which is good), be consistent. You don't use it
> for 'bool bold' in this file when you could as well.

Done.

https://codereview.chromium.org/1569113002/diff/470001/ui/views/style/mac/dia...
File ui/views/style/mac/dialog_button_border_mac.h (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/views/style/mac/dia...
ui/views/style/mac/dialog_button_border_mac.h:22: static bool ShowsDefault(const
CustomButton& button);
On 2016/04/07 17:16:31, sky wrote:
> static function are after constructor/destructor.
> ShouldRenderDefault?

Done x2.

https://codereview.chromium.org/1569113002/diff/470001/ui/views/style/platfor...
File ui/views/style/platform_style.h (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/views/style/platfor...
ui/views/style/platform_style.h:27: typedef SkColor
ButtonColorByState[Button::STATE_COUNT];
On 2016/04/07 17:16:31, sky wrote:
> using?

Done.

[sky, 2016-04-08 16:24:23]

LGTM - if you want to remove the caching of font list you can do it in another
cl.

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/1569113002/diff/470001/ui/views/controls/butt...
ui/views/controls/button/label_button.cc:162: bool bold =
PlatformStyle::kDefaultLabelButtonHasBoldFont && is_default_;
On 2016/04/08 08:35:33, tapted wrote:
> On 2016/04/07 17:16:31, sky wrote:
> > Seems like you can skip cached_bold_font_list_ entirely if
> > kDefaultLabelButtonHasBoldFont is false. Maybe make cached_bold_font_list_ 
a
> > scoped_ptr?
> 
> gfx::FontList is itself just a scoped_refptr, and default-constructing a
> gfx::FontList is cheap now that it just references `g_default_impl` in
> font_list.cc. So a scoped_ptr might not add much. However, you're right that
I'm
> missing out on cases where it's fine to leave cached_bold_font_list_
untouched,
> so I've fixed that.
> 
> 
> (I guess an orthogonal question is whether the caching really adds much on any
> platform, since it should be rare for a button to switch between
> SetIsDefault(true/false)...)

I think you're right and am fine to nuke the caching. I think that will simplify
the code too.

[tapted, 2016-04-11 00:11:06]

The CQ bit was checked by tapted@chromium.org

[tapted, 2016-04-11 00:11:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/1569113002/#ps530001
(title: "respond to comments")

[commit-bot: I haz the power, 2016-04-11 00:11:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1569113002/530001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1569113002/530001

[commit-bot: I haz the power, 2016-04-11 00:51:14]

Description was changed from

==========
MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this 
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Updates views_examples so that all buttons in the example page can be
toggled "default" (currently only the first button can be, which isn't
STYLE_BUTTON).

Screenshots: http://crbug.com/543686#c5 #c6

BUG=543686
==========

to

==========
MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this 
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Updates views_examples so that all buttons in the example page can be
toggled "default" (currently only the first button can be, which isn't
STYLE_BUTTON).

Screenshots: http://crbug.com/543686#c5 #c6

BUG=543686
==========

[commit-bot: I haz the power, 2016-04-11 00:51:15]

Committed patchset #12 (id:530001)

[commit-bot: I haz the power, 2016-04-11 00:52:15]

Description was changed from

==========
MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this 
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Updates views_examples so that all buttons in the example page can be
toggled "default" (currently only the first button can be, which isn't
STYLE_BUTTON).

Screenshots: http://crbug.com/543686#c5 #c6

BUG=543686
==========

to

==========
MacViews: Style BUTTON_STYLE buttons using the "modern" UI

Currently BUTTON_STYLE LabelButtons on Mac are styled using the
webui-like "ConstrainedWindowButton" style which is used in various
places in the Cocoa UI but nobody likes it. The first phase of
toolkit-views dialogs on Mac will be replacing Cocoa dialogs using this
"constrained" button style, with a more modern style, drawn in Skia.

This CL hooks up that style to views::Label button, with some small
behaviour changes for "default" buttons, and a changing font color.

It handles:
- Default buttons on Mac shouldn't get a bold font.
- Instead, the font changes color so ensure SetIsDefault invalidates
that correctly.
- The minimum button size should be smaller on Mac.

Shares the background gradient calculation with comboboxes, and tweaks
the API slightly to support "highlighted" buttons (i.e. default).

Updates views_examples so that all buttons in the example page can be
toggled "default" (currently only the first button can be, which isn't
STYLE_BUTTON).

Screenshots: http://crbug.com/543686#c5 #c6

BUG=543686

Committed: https://crrev.com/b43f95769ea64a0b000cf524a9d75df1f73e40ed
Cr-Commit-Position: refs/heads/master@{#386322}
==========

[commit-bot: I haz the power, 2016-04-11 00:52:16]

Patchset 12 (id:??) landed as
https://crrev.com/b43f95769ea64a0b000cf524a9d75df1f73e40ed
Cr-Commit-Position: refs/heads/master@{#386322}