MacViews: Style BUTTON_STYLE buttons using the "modern" UI

ui/views/controls/button/custom_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/custom_button.h"
 
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/events/event.h"
 #include "ui/events/event_utils.h"
@@ skipping 62 matching lines @@
 // CustomButton, public:
 
 // static
 const char CustomButton::kViewClassName[] = "CustomButton";
 
 // static
 const CustomButton* CustomButton::AsCustomButton(const views::View* view) {
   return AsCustomButton(const_cast<views::View*>(view));
 }
 
+// static
 CustomButton* CustomButton::AsCustomButton(views::View* view) {
   if (view) {
     const char* classname = view->GetClassName();
     if (!strcmp(classname, Checkbox::kViewClassName) ||
         !strcmp(classname, CustomButton::kViewClassName) ||
         !strcmp(classname, ImageButton::kViewClassName) ||
         !strcmp(classname, LabelButton::kViewClassName) ||
         !strcmp(classname, RadioButton::kViewClassName) ||
         !strcmp(classname, MenuButton::kViewClassName)) {
       return static_cast<CustomButton*>(view);
     }
   }
-  return NULL;
+  return nullptr;
+}
+
+// static
+const LabelButton* CustomButton::AsLabelButton(const views::View* view) {
+  return AsLabelButton(const_cast<views::View*>(view));
+}
+
+// static
+LabelButton* CustomButton::AsLabelButton(views::View* view) {
+  if (view) {
+    const char* classname = view->GetClassName();
+    if (!strcmp(classname, Checkbox::kViewClassName) ||

[Elly Fong-Jones, 2016/04/05 16:43:25]

This seems a little weird... if anyone adds another "LabelButton-like" later,
they'll have to know about this code to update it. I can't really think of
anything better to do but I'm not that thrilled with this code.

[tapted, 2016/04/06 12:08:33]

Yeah I agree. However, this is the typical approach, and I put in in
custom_button.cc rather than label_button.cc so at least if one needs to be
updated, there's a better chance that someone will remember to update both.

+        !strcmp(classname, LabelButton::kViewClassName) ||
+        !strcmp(classname, RadioButton::kViewClassName) ||
+        !strcmp(classname, MenuButton::kViewClassName)) {
+      return static_cast<LabelButton*>(view);
+    }
+  }
+  return nullptr;
 }
 
 CustomButton::~CustomButton() {}
 
 void CustomButton::SetState(ButtonState state) {
   if (state == state_)
     return;
 
   if (animate_on_state_change_ &&
       (!is_throbbing_ || !hover_animation_.is_animating())) {
@@ skipping 392 matching lines @@
   Button::NotifyClick(event);
 }
 
 void CustomButton::OnClickCanceled(const ui::Event& event) {
   if (ink_drop_delegate())
     ink_drop_delegate()->OnAction(views::InkDropState::HIDDEN);
   Button::OnClickCanceled(event);
 }
 
 }  // namespace views