Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1568923002: Cleanup includes, comments, and unused code (Closed)

Created:
4 years, 11 months ago by Wei Li
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Cleanup includes, comments, and unused code TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1563673002 . (cherry picked from commit 6664977832350e4a9717bd67b09e3d01196791ba) Committed: https://pdfium.googlesource.com/pdfium/+/aa0f69ae645455e9a290f13572a03f4387ec758a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Wei Li
clean merge, TBR
4 years, 11 months ago (2016-01-07 18:49:23 UTC) #1
Wei Li
Committed patchset #1 (id:1) manually as aa0f69ae645455e9a290f13572a03f4387ec758a (presubmit successful).
4 years, 11 months ago (2016-01-07 18:49:36 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-07 21:30:09 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698