Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1563673002: Cleanup includes, comments, and unused code (Closed)

Created:
4 years, 11 months ago by Wei Li
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Wei Li
PTAL, thanks.
4 years, 11 months ago (2016-01-05 23:59:03 UTC) #2
Lei Zhang
https://codereview.chromium.org/1563673002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp (left): https://codereview.chromium.org/1563673002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp#oldcode7 core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp:7: #include "core/include/fpdfapi/fpdf_parser.h" I moved this up here because it's ...
4 years, 11 months ago (2016-01-06 00:05:34 UTC) #3
Wei Li
https://codereview.chromium.org/1563673002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp (left): https://codereview.chromium.org/1563673002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp#oldcode7 core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp:7: #include "core/include/fpdfapi/fpdf_parser.h" On 2016/01/06 00:05:33, Lei Zhang wrote: > ...
4 years, 11 months ago (2016-01-06 04:46:24 UTC) #4
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-06 09:41:40 UTC) #5
Wei Li
4 years, 11 months ago (2016-01-07 18:30:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6664977832350e4a9717bd67b09e3d01196791ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698