Make CodecBench test kPremul and kUnpremul

Make CodecBench test kPremul and kUnpremul

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1568913002

Committed: https://skia.googlesource.com/skia/+/c7796b93f02e736df967301d3c46cec46dd02d5c

[msarett, 2016-01-07 18:40:45]

Description was changed from

==========
Make CodecBench test kPremul and kUnpremul

BUG=skia:
==========

to

==========
Make CodecBench test kPremul and kUnpremul

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-01-07 18:51:59]

msarett@google.com changed reviewers:
+ scroggo@google.com

[msarett, 2016-01-07 18:51:59]

https://codereview.chromium.org/1568913002/diff/20001/bench/CodecBenchPriv.h
File bench/CodecBenchPriv.h (right):

https://codereview.chromium.org/1568913002/diff/20001/bench/CodecBenchPriv.h#...
bench/CodecBenchPriv.h:33: return "Opaque";
I could be convinced to be silent when the decode is opaque.  For example, if we
are benching jpegs, we don't need to be told over and over that they are opaque.

But I think it is useful to know when a png is opaque vs. not-opaque.  Of
course, we could still figure this out by the absence of a message.

https://codereview.chromium.org/1568913002/diff/20001/bench/nanobench.cpp
File bench/nanobench.cpp (left):

https://codereview.chromium.org/1568913002/diff/20001/bench/nanobench.cpp#old...
bench/nanobench.cpp:760: if (!SkColorTypeValidateAlphaType(colorType,
info.alphaType(),
This will always return true unless:
colorType is not in the SkColorType enum.
alphaType is unknown.

Codec should never suggest these values anyway.

[msarett, 2016-01-07 18:52:09]

Patchset #1 (id:1) has been deleted

[scroggo, 2016-01-07 19:11:20]

lgtm

https://codereview.chromium.org/1568913002/diff/20001/bench/CodecBenchPriv.h
File bench/CodecBenchPriv.h (right):

https://codereview.chromium.org/1568913002/diff/20001/bench/CodecBenchPriv.h#...
bench/CodecBenchPriv.h:33: return "Opaque";
On 2016/01/07 18:51:59, msarett wrote:
> I could be convinced to be silent when the decode is opaque.  For example, if
we
> are benching jpegs, we don't need to be told over and over that they are
opaque.
> 
> But I think it is useful to know when a png is opaque vs. not-opaque.  Of
> course, we could still figure this out by the absence of a message.

I would lean towards being silent.

[msarett, 2016-01-07 19:42:23]

https://codereview.chromium.org/1568913002/diff/20001/bench/CodecBenchPriv.h
File bench/CodecBenchPriv.h (right):

https://codereview.chromium.org/1568913002/diff/20001/bench/CodecBenchPriv.h#...
bench/CodecBenchPriv.h:33: return "Opaque";
On 2016/01/07 19:11:20, scroggo wrote:
> On 2016/01/07 18:51:59, msarett wrote:
> > I could be convinced to be silent when the decode is opaque.  For example,
if
> we
> > are benching jpegs, we don't need to be told over and over that they are
> opaque.
> > 
> > But I think it is useful to know when a png is opaque vs. not-opaque.  Of
> > course, we could still figure this out by the absence of a message.
> 
> I would lean towards being silent.

Done.

[scroggo, 2016-01-07 20:41:18]

lgtm

https://codereview.chromium.org/1568913002/diff/40001/bench/CodecBench.cpp
File bench/CodecBench.cpp (right):

https://codereview.chromium.org/1568913002/diff/40001/bench/CodecBench.cpp#ne...
bench/CodecBench.cpp:21: fName.printf("Codec_%s_%s%s", baseName.c_str(),
color_type_to_str(colorType),
So for a premul, the name will be something like

Codec_file_8888premul

?

Actually, that's not so bad.

[msarett, 2016-01-07 21:00:55]

https://codereview.chromium.org/1568913002/diff/40001/bench/CodecBench.cpp
File bench/CodecBench.cpp (right):

https://codereview.chromium.org/1568913002/diff/40001/bench/CodecBench.cpp#ne...
bench/CodecBench.cpp:21: fName.printf("Codec_%s_%s%s", baseName.c_str(),
color_type_to_str(colorType),
On 2016/01/07 20:41:18, scroggo wrote:
> So for a premul, the name will be something like
> 
> Codec_file_8888premul
> 
> ?
> 
> Actually, that's not so bad.

Yeah it's actually:
N32Premul
N32Unpremul
Index8Premul
Index8Unpremul

Seems fine to me.

[msarett, 2016-01-07 22:03:16]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-01-07 22:03:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1568913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1568913002/40001

[commit-bot: I haz the power, 2016-01-07 22:20:22]

Description was changed from

==========
Make CodecBench test kPremul and kUnpremul

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make CodecBench test kPremul and kUnpremul

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/c7796b93f02e736df967301d3c46cec46dd02d5c
==========

[commit-bot: I haz the power, 2016-01-07 22:20:22]

Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/c7796b93f02e736df967301d3c46cec46dd02d5c