Issue 156883006: Make setting strings consistent in the 2nd person

Issue 156883006: Make setting strings consistent in the 2nd person (Closed)

Created:
6 years, 10 months ago by edwardjung

Modified:
6 years, 10 months ago

Reviewers:
Robert Sesek, Glen Murphy, cpu_(ooo_6.6-7.5), Dan Beam

CC:
chromium-reviews, dbeam+watch-options_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Make setting strings consistent in the 2nd person BUG=156975 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251756

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -49 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	17 chunks	+31 lines, -45 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/app/nibs/FirstRunDialog.xib	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/browser_options_handler.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 10 (0 generated)

edwardjung

Updated Chrome settings text strings. Per http://goo.gl/6614MQ strings which contain PRODUCT_NAME were moved to the ...

6 years, 10 months ago (2014-02-11 18:55:04 UTC) #1

edwardjung

On 2014/02/11 19:01:29, rsesek wrote: > What file(s) would you like me to review? Apologies, ...

6 years, 10 months ago (2014-02-11 20:02:31 UTC) #3

edwardjung

@dbream, I believe I still need an LGTM for the browser_options_handler.cc update. Thanks.

6 years, 10 months ago (2014-02-14 10:40:18 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/edwardjung@chromium.org/156883006/1

6 years, 10 months ago (2014-02-18 10:35:49 UTC) #9

Message was sent while issue was closed.

Change committed as 251756