Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 156883006: Make setting strings consistent in the 2nd person (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/nibs/FirstRunDialog.xib ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/browser_options_handler.h" 5 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "apps/shell_window.h" 10 #include "apps/shell_window.h"
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
427 // Strings with product-name substitutions. 427 // Strings with product-name substitutions.
428 { "syncOverview", IDS_SYNC_OVERVIEW, IDS_PRODUCT_NAME }, 428 { "syncOverview", IDS_SYNC_OVERVIEW, IDS_PRODUCT_NAME },
429 { "syncButtonTextStart", IDS_SYNC_SETUP_BUTTON_LABEL }, 429 { "syncButtonTextStart", IDS_SYNC_SETUP_BUTTON_LABEL },
430 #endif 430 #endif
431 { "syncButtonTextSignIn", IDS_SYNC_START_SYNC_BUTTON_LABEL, 431 { "syncButtonTextSignIn", IDS_SYNC_START_SYNC_BUTTON_LABEL,
432 IDS_SHORT_PRODUCT_NAME }, 432 IDS_SHORT_PRODUCT_NAME },
433 { "profilesSingleUser", IDS_PROFILES_SINGLE_USER_MESSAGE, 433 { "profilesSingleUser", IDS_PROFILES_SINGLE_USER_MESSAGE,
434 IDS_PRODUCT_NAME }, 434 IDS_PRODUCT_NAME },
435 { "defaultBrowserUnknown", IDS_OPTIONS_DEFAULTBROWSER_UNKNOWN, 435 { "defaultBrowserUnknown", IDS_OPTIONS_DEFAULTBROWSER_UNKNOWN,
436 IDS_PRODUCT_NAME }, 436 IDS_PRODUCT_NAME },
437 { "defaultBrowserUseAsDefault", IDS_OPTIONS_DEFAULTBROWSER_USEASDEFAULT, 437 { "defaultBrowserUseAsDefault", IDS_OPTIONS_DEFAULTBROWSER_USEASDEFAULT },
438 IDS_PRODUCT_NAME }, 438 { "autoLaunchText", IDS_AUTOLAUNCH_TEXT },
439 { "autoLaunchText", IDS_AUTOLAUNCH_TEXT, IDS_PRODUCT_NAME },
440 #if defined(OS_CHROMEOS) 439 #if defined(OS_CHROMEOS)
441 { "factoryResetDescription", IDS_OPTIONS_FACTORY_RESET_DESCRIPTION, 440 { "factoryResetDescription", IDS_OPTIONS_FACTORY_RESET_DESCRIPTION,
442 IDS_SHORT_PRODUCT_NAME }, 441 IDS_SHORT_PRODUCT_NAME },
443 #endif 442 #endif
444 { "languageSectionLabel", IDS_OPTIONS_ADVANCED_LANGUAGE_LABEL, 443 { "languageSectionLabel", IDS_OPTIONS_ADVANCED_LANGUAGE_LABEL,
445 IDS_SHORT_PRODUCT_NAME }, 444 IDS_SHORT_PRODUCT_NAME },
446 #if defined(ENABLE_MDNS) 445 #if defined(ENABLE_MDNS)
447 { "cloudPrintDevicesPageButton", IDS_LOCAL_DISCOVERY_DEVICES_PAGE_BUTTON }, 446 { "cloudPrintDevicesPageButton", IDS_LOCAL_DISCOVERY_DEVICES_PAGE_BUTTON },
448 { "cloudPrintEnableNotificationsLabel", 447 { "cloudPrintEnableNotificationsLabel",
449 IDS_LOCAL_DISCOVERY_NOTIFICATIONS_ENABLE_CHECKBOX_LABEL }, 448 IDS_LOCAL_DISCOVERY_NOTIFICATIONS_ENABLE_CHECKBOX_LABEL },
(...skipping 1255 matching lines...) Expand 10 before | Expand all | Expand 10 after
1705 void BrowserOptionsHandler::SetupManagingSupervisedUsers() { 1704 void BrowserOptionsHandler::SetupManagingSupervisedUsers() {
1706 bool has_users = !Profile::FromWebUI(web_ui())-> 1705 bool has_users = !Profile::FromWebUI(web_ui())->
1707 GetPrefs()->GetDictionary(prefs::kManagedUsers)->empty(); 1706 GetPrefs()->GetDictionary(prefs::kManagedUsers)->empty();
1708 base::FundamentalValue has_users_value(has_users); 1707 base::FundamentalValue has_users_value(has_users);
1709 web_ui()->CallJavascriptFunction( 1708 web_ui()->CallJavascriptFunction(
1710 "BrowserOptions.updateManagesSupervisedUsers", 1709 "BrowserOptions.updateManagesSupervisedUsers",
1711 has_users_value); 1710 has_users_value);
1712 } 1711 }
1713 1712
1714 } // namespace options 1713 } // namespace options
OLDNEW
« no previous file with comments | « chrome/app/nibs/FirstRunDialog.xib ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698