Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: pkg/analyzer/lib/src/dart/element/member.dart

Issue 1568643002: clean up generic methods in resolution (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/dart/element/type.dart ('k') | pkg/analyzer/lib/src/dart/element/type.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/element/member.dart
diff --git a/pkg/analyzer/lib/src/dart/element/member.dart b/pkg/analyzer/lib/src/dart/element/member.dart
index 95997758a2b7f229d69142a2bd559e37411fafd9..75dcee658f0a985e06d6165f8d13dac7c86365f0 100644
--- a/pkg/analyzer/lib/src/dart/element/member.dart
+++ b/pkg/analyzer/lib/src/dart/element/member.dart
@@ -339,15 +339,21 @@ class FieldMember extends VariableMember implements FieldElement {
}
/**
+ * Deprecated: this type is no longer used. Use
+ * [MethodInvocation.staticInvokeType] to get the instantiated type of a generic
+ * method invocation.
+ *
* An element of a generic function, where the type parameters are known.
*/
// TODO(jmesserly): the term "function member" is a bit weird, but it allows
// a certain consistency.
+@deprecated
class FunctionMember extends ExecutableMember implements FunctionElement {
/**
* Initialize a newly created element to represent a function, based on the
* [baseElement], with the corresponding function [type].
*/
+ @deprecated
FunctionMember(FunctionElement baseElement, [DartType type])
: super(baseElement, null, type);
@@ -674,12 +680,6 @@ class ParameterMember extends VariableMember
@override
SourceRange get visibleRange => baseElement.visibleRange;
- // TODO(jmesserly): this equality is broken. It should consider the defining
- // type as well, otherwise we're dropping the substitution.
- @override
- bool operator ==(Object object) =>
- object is ParameterMember && baseElement == object.baseElement;
-
@override
accept(ElementVisitor visitor) => visitor.visitParameterElement(this);
« no previous file with comments | « pkg/analyzer/lib/dart/element/type.dart ('k') | pkg/analyzer/lib/src/dart/element/type.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698