clean up generic methods in resolution

pkg/analyzer/lib/src/dart/element/member.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.dart.element.member;
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/dart/element/type.dart';
@@ skipping 321 matching lines @@
         if (basePropagatedType != substitutedPropagatedType) {
           return true;
         }
       }
     }
     return false;
   }
 }
 
 /**
+ * Deprecated: this type is no longer used. Use
+ * [MethodInvocation.staticInvokeType] to get the instantiated type of a generic
+ * method invocation.
+ *
  * An element of a generic function, where the type parameters are known.
  */
 // TODO(jmesserly): the term "function member" is a bit weird, but it allows
 // a certain consistency.
+@deprecated
 class FunctionMember extends ExecutableMember implements FunctionElement {
   /**
    * Initialize a newly created element to represent a function, based on the
    * [baseElement], with the corresponding function [type].
    */
+  @deprecated
   FunctionMember(FunctionElement baseElement, [DartType type])
       : super(baseElement, null, type);
 
   @override
   FunctionElement get baseElement => super.baseElement as FunctionElement;
 
   @override
   Element get enclosingElement => baseElement.enclosingElement;
 
   @override
@@ skipping 306 matching lines @@
     }
     return ParameterElement.EMPTY_LIST;
   }
 
   @override
   List<TypeParameterElement> get typeParameters => baseElement.typeParameters;
 
   @override
   SourceRange get visibleRange => baseElement.visibleRange;
 
-  // TODO(jmesserly): this equality is broken. It should consider the defining
-  // type as well, otherwise we're dropping the substitution.
-  @override
-  bool operator ==(Object object) =>
-      object is ParameterMember && baseElement == object.baseElement;
-
   @override
   accept(ElementVisitor visitor) => visitor.visitParameterElement(this);
 
   @override
   FormalParameter computeNode() => baseElement.computeNode();
 
   @override
   Element getAncestor(Predicate<Element> predicate) {
     Element element = baseElement.getAncestor(predicate);
     ParameterizedType definingType = this.definingType;
@@ skipping 266 matching lines @@
   bool get isStatic => baseElement.isStatic;
 
   @override
   void visitChildren(ElementVisitor visitor) {
     // TODO(brianwilkerson) We need to finish implementing the accessors used
     // below so that we can safely invoke them.
     super.visitChildren(visitor);
     safelyVisitChild(baseElement.initializer, visitor);
   }
 }