Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 156863005: [PPAPI][MediaStream] Rename AudioFrame to AudioBuffer (Closed)

Created:
6 years, 10 months ago by Peng
Modified:
6 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, yusukes+watch_chromium.org, tzik, Ilya Sherman, raymes+watch_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, Sam Clegg, nfullagar1, piman+watch_chromium.org, noelallen1, jar (doing other things), binji, ihf+watch_chromium.org, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@frame_to_buffer
Visibility:
Public.

Description

[PPAPI][MediaStream] Rename AudioFrame to AudioBuffer For audio, a frame usually has the same meaning as sample, so AudioFrame is not a good name for a bunch of audio samples. Change it to AudioBuffer. BUG=330851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250460

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Update #

Total comments: 4

Patch Set 4 : Fix review issues and update cc wrapper #

Total comments: 4

Patch Set 5 : Fix review issues #

Patch Set 6 : Add a missing file #

Patch Set 7 : Fix build errors #

Total comments: 2

Patch Set 8 : Fix review issues #

Patch Set 9 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+862 lines, -1068 lines) Patch
M chrome/browser/component_updater/ppapi_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_audio_track_host.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 2 chunks +2 lines, -2 lines 0 comments Download
A ppapi/api/ppb_audio_buffer.idl View 2 3 4 5 1 chunk +132 lines, -0 lines 0 comments Download
D ppapi/api/ppb_audio_frame.idl View 1 chunk +0 lines, -132 lines 0 comments Download
M ppapi/api/ppb_media_stream_audio_track.idl View 1 2 3 5 chunks +47 lines, -48 lines 0 comments Download
A ppapi/c/ppb_audio_buffer.h View 2 3 4 5 1 chunk +146 lines, -0 lines 0 comments Download
D ppapi/c/ppb_audio_frame.h View 1 chunk +0 lines, -146 lines 0 comments Download
M ppapi/c/ppb_media_stream_audio_track.h View 1 2 3 6 chunks +47 lines, -48 lines 0 comments Download
A ppapi/cpp/audio_buffer.h View 2 3 4 5 1 chunk +85 lines, -0 lines 0 comments Download
A ppapi/cpp/audio_buffer.cc View 2 3 4 5 1 chunk +91 lines, -0 lines 0 comments Download
D ppapi/cpp/audio_frame.h View 1 chunk +0 lines, -85 lines 0 comments Download
D ppapi/cpp/audio_frame.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M ppapi/cpp/media_stream_audio_track.h View 1 2 3 4 chunks +35 lines, -37 lines 0 comments Download
M ppapi/cpp/media_stream_audio_track.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M ppapi/cpp/media_stream_video_track.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/examples/media_stream_audio/media_stream_audio.cc View 1 2 3 4 5 6 7 8 5 chunks +18 lines, -18 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 5 chunks +11 lines, -11 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
A + ppapi/proxy/audio_buffer_resource.h View 3 chunks +15 lines, -14 lines 0 comments Download
A + ppapi/proxy/audio_buffer_resource.cc View 9 chunks +19 lines, -19 lines 0 comments Download
D ppapi/proxy/audio_frame_resource.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ppapi/proxy/audio_frame_resource.cc View 1 chunk +0 lines, -112 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/media_stream_audio_track_resource.h View 2 chunks +11 lines, -11 lines 0 comments Download
M ppapi/proxy/media_stream_audio_track_resource.cc View 4 chunks +40 lines, -40 lines 0 comments Download
M ppapi/shared_impl/media_stream_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/shared_impl/resource.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/all_cpp_includes.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev_channel.h View 1 chunk +1 line, -1 line 0 comments Download
A + ppapi/thunk/ppb_audio_buffer_api.h View 3 chunks +8 lines, -8 lines 0 comments Download
A ppapi/thunk/ppb_audio_buffer_thunk.cc View 1 2 3 4 5 1 chunk +108 lines, -0 lines 0 comments Download
D ppapi/thunk/ppb_audio_frame_api.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ppapi/thunk/ppb_audio_frame_thunk.cc View 1 chunk +0 lines, -108 lines 0 comments Download
M ppapi/thunk/ppb_media_stream_audio_track_api.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_media_stream_audio_track_thunk.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Peng
Hi, Yuzhu, David, This CL renames AudioFrame to AudioBuffer, PTAL. And the c++ wrapper is ...
6 years, 10 months ago (2014-02-07 15:53:37 UTC) #1
Peng
On 2014/02/07 15:53:37, Peng wrote: > Hi, Yuzhu, David, > > This CL renames AudioFrame ...
6 years, 10 months ago (2014-02-07 19:15:15 UTC) #2
dmichael (off chromium)
lgtm, thanks! https://codereview.chromium.org/156863005/diff/50001/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c (right): https://codereview.chromium.org/156863005/diff/50001/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c#newcode250 ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c:250: /* Not generating wrapper methods for PPB_AudioBuffer_0_1 ...
6 years, 10 months ago (2014-02-07 19:25:12 UTC) #3
yzshen1
Reviewed the C API, which looks good. Will take another look once the cpp API ...
6 years, 10 months ago (2014-02-07 19:30:51 UTC) #4
binji
native_client_sdk lgtm
6 years, 10 months ago (2014-02-07 19:33:49 UTC) #5
jvoung (off chromium)
https://codereview.chromium.org/156863005/diff/50001/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c (right): https://codereview.chromium.org/156863005/diff/50001/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c#newcode250 ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c:250: /* Not generating wrapper methods for PPB_AudioBuffer_0_1 */ On ...
6 years, 10 months ago (2014-02-07 19:33:49 UTC) #6
Peng
Hi Yuzhu, cc wrapper has been updated. PTAL https://codereview.chromium.org/156863005/diff/50001/ppapi/api/ppb_media_stream_audio_track.idl File ppapi/api/ppb_media_stream_audio_track.idl (right): https://codereview.chromium.org/156863005/diff/50001/ppapi/api/ppb_media_stream_audio_track.idl#newcode81 ppapi/api/ppb_media_stream_audio_track.idl:81: * ...
6 years, 10 months ago (2014-02-07 19:59:34 UTC) #7
Peng
On 2014/02/07 19:59:34, Peng wrote: > Hi Yuzhu, cc wrapper has been updated. PTAL > ...
6 years, 10 months ago (2014-02-07 20:03:13 UTC) #8
yzshen1
LGTM with two nits. https://codereview.chromium.org/156863005/diff/170001/ppapi/ppapi_sources.gypi File ppapi/ppapi_sources.gypi (right): https://codereview.chromium.org/156863005/diff/170001/ppapi/ppapi_sources.gypi#newcode29 ppapi/ppapi_sources.gypi:29: 'c/ppb_audio_buffer.h', reorder, please. https://codereview.chromium.org/156863005/diff/170001/ppapi/ppapi_sources.gypi#newcode162 ppapi/ppapi_sources.gypi:162: ...
6 years, 10 months ago (2014-02-07 20:16:52 UTC) #9
Peng
Thanks. https://codereview.chromium.org/156863005/diff/170001/ppapi/ppapi_sources.gypi File ppapi/ppapi_sources.gypi (right): https://codereview.chromium.org/156863005/diff/170001/ppapi/ppapi_sources.gypi#newcode29 ppapi/ppapi_sources.gypi:29: 'c/ppb_audio_buffer.h', On 2014/02/07 20:16:53, yzshen1 wrote: > reorder, ...
6 years, 10 months ago (2014-02-07 20:43:33 UTC) #10
Peng
+asvitkine, for tools/metrics/histograms/histograms.xml too, seems isherman has a lot of pending CLs. Thanks. On 2014/02/07 ...
6 years, 10 months ago (2014-02-10 22:57:22 UTC) #11
Alexei Svitkine (slow)
https://codereview.chromium.org/156863005/diff/410001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/156863005/diff/410001/tools/metrics/histograms/histograms.xml#oldcode29527 tools/metrics/histograms/histograms.xml:29527: - <int value="910782902" label="PPB_AudioFrame;0.1"/> Don't remove entries from this ...
6 years, 10 months ago (2014-02-11 15:25:26 UTC) #12
Peng
https://codereview.chromium.org/156863005/diff/410001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/156863005/diff/410001/tools/metrics/histograms/histograms.xml#oldcode29527 tools/metrics/histograms/histograms.xml:29527: - <int value="910782902" label="PPB_AudioFrame;0.1"/> On 2014/02/11 15:25:27, Alexei Svitkine ...
6 years, 10 months ago (2014-02-11 15:39:16 UTC) #13
Alexei Svitkine (slow)
histograms lgtm
6 years, 10 months ago (2014-02-11 15:55:56 UTC) #14
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 10 months ago (2014-02-11 15:56:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/156863005/530001
6 years, 10 months ago (2014-02-11 15:57:08 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-11 16:44:57 UTC) #17
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=123535
6 years, 10 months ago (2014-02-11 16:44:58 UTC) #18
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 10 months ago (2014-02-11 17:04:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/156863005/810001
6 years, 10 months ago (2014-02-11 17:04:16 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 18:59:09 UTC) #21
Message was sent while issue was closed. 
Change committed as 250460

Powered by Google App Engine
This is Rietveld 408576698