Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: ppapi/proxy/media_stream_audio_track_resource.cc

Issue 156863005: [PPAPI][MediaStream] Rename AudioFrame to AudioBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@frame_to_buffer
Patch Set: Update Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/proxy/media_stream_audio_track_resource.h" 5 #include "ppapi/proxy/media_stream_audio_track_resource.h"
6 6
7 #include "ppapi/proxy/audio_frame_resource.h" 7 #include "ppapi/proxy/audio_buffer_resource.h"
8 #include "ppapi/shared_impl/media_stream_buffer.h" 8 #include "ppapi/shared_impl/media_stream_buffer.h"
9 #include "ppapi/shared_impl/var.h" 9 #include "ppapi/shared_impl/var.h"
10 10
11 namespace ppapi { 11 namespace ppapi {
12 namespace proxy { 12 namespace proxy {
13 13
14 MediaStreamAudioTrackResource::MediaStreamAudioTrackResource( 14 MediaStreamAudioTrackResource::MediaStreamAudioTrackResource(
15 Connection connection, 15 Connection connection,
16 PP_Instance instance, 16 PP_Instance instance,
17 int pending_renderer_id, 17 int pending_renderer_id,
18 const std::string& id) 18 const std::string& id)
19 : MediaStreamTrackResourceBase( 19 : MediaStreamTrackResourceBase(
20 connection, instance, pending_renderer_id, id), 20 connection, instance, pending_renderer_id, id),
21 get_frame_output_(NULL) { 21 get_buffer_output_(NULL) {
22 } 22 }
23 23
24 MediaStreamAudioTrackResource::~MediaStreamAudioTrackResource() { 24 MediaStreamAudioTrackResource::~MediaStreamAudioTrackResource() {
25 Close(); 25 Close();
26 } 26 }
27 27
28 thunk::PPB_MediaStreamAudioTrack_API* 28 thunk::PPB_MediaStreamAudioTrack_API*
29 MediaStreamAudioTrackResource::AsPPB_MediaStreamAudioTrack_API() { 29 MediaStreamAudioTrackResource::AsPPB_MediaStreamAudioTrack_API() {
30 return this; 30 return this;
31 } 31 }
(...skipping 13 matching lines...) Expand all
45 return PP_ERROR_NOTSUPPORTED; 45 return PP_ERROR_NOTSUPPORTED;
46 } 46 }
47 47
48 int32_t MediaStreamAudioTrackResource::GetAttrib( 48 int32_t MediaStreamAudioTrackResource::GetAttrib(
49 PP_MediaStreamAudioTrack_Attrib attrib, 49 PP_MediaStreamAudioTrack_Attrib attrib,
50 int32_t* value) { 50 int32_t* value) {
51 // TODO(penghuang): Implement this function. 51 // TODO(penghuang): Implement this function.
52 return PP_ERROR_NOTSUPPORTED; 52 return PP_ERROR_NOTSUPPORTED;
53 } 53 }
54 54
55 int32_t MediaStreamAudioTrackResource::GetFrame( 55 int32_t MediaStreamAudioTrackResource::GetBuffer(
56 PP_Resource* frame, 56 PP_Resource* buffer,
57 scoped_refptr<TrackedCallback> callback) { 57 scoped_refptr<TrackedCallback> callback) {
58 if (has_ended()) 58 if (has_ended())
59 return PP_ERROR_FAILED; 59 return PP_ERROR_FAILED;
60 60
61 if (TrackedCallback::IsPending(get_frame_callback_)) 61 if (TrackedCallback::IsPending(get_buffer_callback_))
62 return PP_ERROR_INPROGRESS; 62 return PP_ERROR_INPROGRESS;
63 63
64 *frame = GetAudioFrame(); 64 *buffer = GetAudioBuffer();
65 if (*frame) 65 if (*buffer)
66 return PP_OK; 66 return PP_OK;
67 67
68 // TODO(penghuang): Use the callback as hints to determine which thread will 68 // TODO(penghuang): Use the callback as hints to determine which thread will
69 // use the resource, so we could deliver frames to the target thread directly 69 // use the resource, so we could deliver buffers to the target thread directly
70 // for better performance. 70 // for better performance.
71 get_frame_output_ = frame; 71 get_buffer_output_ = buffer;
72 get_frame_callback_ = callback; 72 get_buffer_callback_ = callback;
73 return PP_OK_COMPLETIONPENDING; 73 return PP_OK_COMPLETIONPENDING;
74 } 74 }
75 75
76 int32_t MediaStreamAudioTrackResource::RecycleFrame(PP_Resource frame) { 76 int32_t MediaStreamAudioTrackResource::RecycleBuffer(PP_Resource buffer) {
77 FrameMap::iterator it = frames_.find(frame); 77 BufferMap::iterator it = buffers_.find(buffer);
78 if (it == frames_.end()) 78 if (it == buffers_.end())
79 return PP_ERROR_BADRESOURCE; 79 return PP_ERROR_BADRESOURCE;
80 80
81 scoped_refptr<AudioFrameResource> frame_resource = it->second; 81 scoped_refptr<AudioBufferResource> buffer_resource = it->second;
82 frames_.erase(it); 82 buffers_.erase(it);
83 83
84 if (has_ended()) 84 if (has_ended())
85 return PP_OK; 85 return PP_OK;
86 86
87 DCHECK_GE(frame_resource->GetBufferIndex(), 0); 87 DCHECK_GE(buffer_resource->GetBufferIndex(), 0);
88 88
89 SendEnqueueBufferMessageToHost(frame_resource->GetBufferIndex()); 89 SendEnqueueBufferMessageToHost(buffer_resource->GetBufferIndex());
90 frame_resource->Invalidate(); 90 buffer_resource->Invalidate();
91 return PP_OK; 91 return PP_OK;
92 } 92 }
93 93
94 void MediaStreamAudioTrackResource::Close() { 94 void MediaStreamAudioTrackResource::Close() {
95 if (has_ended()) 95 if (has_ended())
96 return; 96 return;
97 97
98 if (TrackedCallback::IsPending(get_frame_callback_)) { 98 if (TrackedCallback::IsPending(get_buffer_callback_)) {
99 *get_frame_output_ = 0; 99 *get_buffer_output_ = 0;
100 get_frame_callback_->PostAbort(); 100 get_buffer_callback_->PostAbort();
101 get_frame_callback_ = NULL; 101 get_buffer_callback_ = NULL;
102 get_frame_output_ = 0; 102 get_buffer_output_ = 0;
103 } 103 }
104 104
105 ReleaseFrames(); 105 ReleaseBuffers();
106 MediaStreamTrackResourceBase::CloseInternal(); 106 MediaStreamTrackResourceBase::CloseInternal();
107 } 107 }
108 108
109 void MediaStreamAudioTrackResource::OnNewBufferEnqueued() { 109 void MediaStreamAudioTrackResource::OnNewBufferEnqueued() {
110 if (!TrackedCallback::IsPending(get_frame_callback_)) 110 if (!TrackedCallback::IsPending(get_buffer_callback_))
111 return; 111 return;
112 112
113 *get_frame_output_ = GetAudioFrame(); 113 *get_buffer_output_ = GetAudioBuffer();
114 int32_t result = *get_frame_output_ ? PP_OK : PP_ERROR_FAILED; 114 int32_t result = *get_buffer_output_ ? PP_OK : PP_ERROR_FAILED;
115 get_frame_output_ = NULL; 115 get_buffer_output_ = NULL;
116 scoped_refptr<TrackedCallback> callback; 116 scoped_refptr<TrackedCallback> callback;
117 callback.swap(get_frame_callback_); 117 callback.swap(get_buffer_callback_);
118 callback->Run(result); 118 callback->Run(result);
119 } 119 }
120 120
121 PP_Resource MediaStreamAudioTrackResource::GetAudioFrame() { 121 PP_Resource MediaStreamAudioTrackResource::GetAudioBuffer() {
122 int32_t index = buffer_manager()->DequeueBuffer(); 122 int32_t index = buffer_manager()->DequeueBuffer();
123 if (index < 0) 123 if (index < 0)
124 return 0; 124 return 0;
125 125
126 MediaStreamBuffer* buffer = buffer_manager()->GetBufferPointer(index); 126 MediaStreamBuffer* buffer = buffer_manager()->GetBufferPointer(index);
127 DCHECK(buffer); 127 DCHECK(buffer);
128 scoped_refptr<AudioFrameResource> resource = 128 scoped_refptr<AudioBufferResource> resource =
129 new AudioFrameResource(pp_instance(), index, buffer); 129 new AudioBufferResource(pp_instance(), index, buffer);
130 // Add |pp_resource()| and |resource| into |frames_|. 130 // Add |pp_resource()| and |resource| into |buffers_|.
131 // |frames_| uses scoped_ptr<> to hold a ref of |resource|. It keeps the 131 // |buffers_| uses scoped_ptr<> to hold a ref of |resource|. It keeps the
132 // resource alive. 132 // resource alive.
133 frames_.insert(FrameMap::value_type(resource->pp_resource(), resource)); 133 buffers_.insert(BufferMap::value_type(resource->pp_resource(), resource));
134 return resource->GetReference(); 134 return resource->GetReference();
135 } 135 }
136 136
137 void MediaStreamAudioTrackResource::ReleaseFrames() { 137 void MediaStreamAudioTrackResource::ReleaseBuffers() {
138 FrameMap::iterator it = frames_.begin(); 138 BufferMap::iterator it = buffers_.begin();
139 while (it != frames_.end()) { 139 while (it != buffers_.end()) {
140 // Just invalidate and release VideoFrameResorce, but keep PP_Resource. 140 // Just invalidate and release VideoBufferResorce, but keep PP_Resource.
141 // So plugin can still use |RecycleFrame()|. 141 // So plugin can still use |RecycleBuffer()|.
142 it->second->Invalidate(); 142 it->second->Invalidate();
143 it->second = NULL; 143 it->second = NULL;
144 } 144 }
145 } 145 }
146 146
147 } // namespace proxy 147 } // namespace proxy
148 } // namespace ppapi 148 } // namespace ppapi
OLDNEW
« no previous file with comments | « ppapi/proxy/media_stream_audio_track_resource.h ('k') | ppapi/shared_impl/media_stream_buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698