Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1568623003: Add VSUB{S,D} instructions to the integrated ARM assembler. (Closed)

Created:
4 years, 11 months ago by Karl
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add vsub test cases. #

Patch Set 3 : Add vsub test cases. #

Total comments: 2

Patch Set 4 : Add comments to DART assembler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -11 lines) Patch
M src/DartARM32/assembler_arm.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 chunk +30 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +19 lines, -2 lines 0 comments Download
M tests_lit/assembler/arm32/vadd.ll View 2 chunks +27 lines, -6 lines 0 comments Download
A tests_lit/assembler/arm32/vsub.ll View 1 2 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 11 months ago (2016-01-07 17:16:05 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1568623003/diff/40001/src/DartARM32/assembler_arm.h File src/DartARM32/assembler_arm.h (right): https://codereview.chromium.org/1568623003/diff/40001/src/DartARM32/assembler_arm.h#newcode658 src/DartARM32/assembler_arm.h:658: #if 0 Add the usual comments about where ...
4 years, 11 months ago (2016-01-07 18:00:45 UTC) #4
Karl
Committed patchset #4 (id:60001) manually as b3e2574c24ea0e81bbcb9c105a4cb153551a48f2 (presubmit successful).
4 years, 11 months ago (2016-01-07 18:20:31 UTC) #6
Karl
4 years, 11 months ago (2016-01-07 18:20:43 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1568623003/diff/40001/src/DartARM32/assembler...
File src/DartARM32/assembler_arm.h (right):

https://codereview.chromium.org/1568623003/diff/40001/src/DartARM32/assembler...
src/DartARM32/assembler_arm.h:658: #if 0
On 2016/01/07 18:00:45, stichnot wrote:
> Add the usual comments about where these moved?

Done.

Powered by Google App Engine
This is Rietveld 408576698