Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1568513002: fix valgrind (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix valgrind (A recently added fuzzer test broke the valgrind bot, intentionally, to isolate an uninitialized memory bug.) If the conic has ordered points, but cannot be broken into parts, treat it as if it were monotonic. R=reed@google.com BUG=skia:4757 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1568513002 Committed: https://skia.googlesource.com/skia/+/e114dd63161b5efffbffb17e4d3facad77f34507

Patch Set 1 #

Total comments: 1

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M src/core/SkPath.cpp View 1 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1568513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1568513002/1
4 years, 11 months ago (2016-01-06 15:59:41 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 11 months ago (2016-01-06 15:59:42 UTC) #4
reed1
lgtm w/ request for comment https://codereview.chromium.org/1568513002/diff/1/src/core/SkPath.cpp File src/core/SkPath.cpp (right): https://codereview.chromium.org/1568513002/diff/1/src/core/SkPath.cpp#newcode2768 src/core/SkPath.cpp:2768: bool isMono = is_mono_quad(pts[0].fY, ...
4 years, 11 months ago (2016-01-06 16:12:06 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 16:15:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e114dd63161b5efffbffb17e4d3facad77f34507

Powered by Google App Engine
This is Rietveld 408576698