fix valgrind

src/core/SkPath.cpp

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkBuffer.h"
 #include "SkCubicClipper.h"
 #include "SkErrorInternals.h"
@@ skipping 2746 matching lines @@
     if (y0 < y1) {
         return y1 <= y2;
     } else {
         return y1 >= y2;
     }
 }
 
 static int winding_conic(const SkPoint pts[], SkScalar x, SkScalar y, SkScalar weight,
                          int* onCurveCount) {
     SkConic conic(pts, weight);
-    SkConic *c = &conic;
     SkConic chopped[2];
-    int     n = 0;
-
-    if (!is_mono_quad(pts[0].fY, pts[1].fY, pts[2].fY)) {
-        n = conic.chopAtYExtrema(chopped);
-        c = chopped;
-    }
-    int w = winding_mono_conic(*c, x, y, onCurveCount);
-    if (n > 0) {
+    bool isMono = is_mono_quad(pts[0].fY, pts[1].fY, pts[2].fY) || !conic.chopAtYExtrema(chopped);

[reed1, 2016/01/06 16:12:06]

maybe a comment describing why we check for the chopper possibly failing, even
though the control points are known to be non-monotonic

+    int w = winding_mono_conic(isMono ? conic : chopped[0], x, y, onCurveCount);
+    if (!isMono) {
         w += winding_mono_conic(chopped[1], x, y, onCurveCount);
     }
     return w;
 }
 
 static int winding_mono_quad(const SkPoint pts[], SkScalar x, SkScalar y, int* onCurveCount) {
     SkScalar y0 = pts[0].fY;
     SkScalar y2 = pts[2].fY;
 
     int dir = 1;
@@ skipping 304 matching lines @@
         }
     } while (!done);
     return SkToBool(tangents.count()) ^ isInverse;
 }
 
 int SkPath::ConvertConicToQuads(const SkPoint& p0, const SkPoint& p1, const SkPoint& p2,
                                 SkScalar w, SkPoint pts[], int pow2) {
     const SkConic conic(p0, p1, p2, w);
     return conic.chopIntoQuadsPOW2(pts, pow2);
 }