Part 2/3 (GL) of adding with device scale factor to transport surfaces

Part 2/3 (GL) of adding with device scale factor to transport surfaces

Add a scale factor argument to glResizeCHROMIUM.

Pass the scale factor on to the resize callback in ImageTransportSurface,
and drop it on the floor there.

BUG=132714
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202325

[ccameron, 2013-05-22 08:38:31]

Adding piman for gpu/ changes.

This is part 2 of a 3-part series which sends the correct
scale factor to CompositingIOSurfaceMac, to avoid scaled
flickering when moving across screens.

The previous and subsequent parts are
https://codereview.chromium.org/15688002/ (compositor)
https://codereview.chromium.org/15685003/ (GL) -- this change
https://codereview.chromium.org/15689003/ (RWH/IOSurface)

https://codereview.chromium.org/15685003/diff/1/content/common/gpu/image_tran...
File content/common/gpu/image_transport_surface_mac.cc (right):

https://codereview.chromium.org/15685003/diff/1/content/common/gpu/image_tran...
content/common/gpu/image_transport_surface_mac.cc:304: scale_factor_ =
scale_factor;
This is where we drop off scale_factor. In the next change, we will pick it up
in the SwapBuffers IPCs, https://codereview.chromium.org/15689003/

https://codereview.chromium.org/15685003/diff/1/ppapi/shared_impl/ppb_graphic...
File ppapi/shared_impl/ppb_graphics_3d_shared.cc (right):

https://codereview.chromium.org/15685003/diff/1/ppapi/shared_impl/ppb_graphic...
ppapi/shared_impl/ppb_graphics_3d_shared.cc:54:
gles2_impl()->ResizeCHROMIUM(width, height, 1.f);
This seemed questionable to me, put pepper flash worked transitioning between
hidpi and non-hidpi screens, and going in and out of fullscreen on both.

[piman, 2013-05-22 19:41:14]

Thanks for tackling this problem!
Couple of things, but good to go after that.

https://codereview.chromium.org/15685003/diff/1/content/common/gpu/texture_im...
File content/common/gpu/texture_image_transport_surface.cc (right):

https://codereview.chromium.org/15685003/diff/1/content/common/gpu/texture_im...
content/common/gpu/texture_image_transport_surface.cc:172: float scale_factor) {
I think we want to fix the issue on Aura as well. Can we stash the scale_factor
here, like on mac, and (in the later patch) also send it on
SwapBuffers/PostSubBuffer ?

https://codereview.chromium.org/15685003/diff/1/gpu/command_buffer/service/gl...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/15685003/diff/1/gpu/command_buffer/service/gl...
gpu/command_buffer/service/gles2_cmd_decoder.cc:3431: GLfloat scale_factor =
static_cast<GLuint>(c.scale_factor);
static_cast<GLuint> is certainly wrong.
I think you don't need a cast at all.

https://codereview.chromium.org/15685003/diff/1/ppapi/shared_impl/ppb_graphic...
File ppapi/shared_impl/ppb_graphics_3d_shared.cc (right):

https://codereview.chromium.org/15685003/diff/1/ppapi/shared_impl/ppb_graphic...
ppapi/shared_impl/ppb_graphics_3d_shared.cc:54:
gles2_impl()->ResizeCHROMIUM(width, height, 1.f);
On 2013/05/22 08:38:31, ccameron1 wrote:
> This seemed questionable to me, put pepper flash worked transitioning between
> hidpi and non-hidpi screens, and going in and out of fullscreen on both.

It's ok. Hi-DPI is handled separately in Flash. Also, the scale factor is
actually ignored in the decoder for the "parenting" case - see the is_offscreen
case in GLES2DecoderImpl::HandleResizeCHROMIUM

[ccameron, 2013-05-22 20:00:05]

Thanks!!

https://codereview.chromium.org/15685003/diff/1/content/common/gpu/texture_im...
File content/common/gpu/texture_image_transport_surface.cc (right):

https://codereview.chromium.org/15685003/diff/1/content/common/gpu/texture_im...
content/common/gpu/texture_image_transport_surface.cc:172: float scale_factor) {
On 2013/05/22 19:41:14, piman wrote:
> I think we want to fix the issue on Aura as well. Can we stash the
scale_factor
> here, like on mac, and (in the later patch) also send it on
> SwapBuffers/PostSubBuffer ?

Done.

https://codereview.chromium.org/15685003/diff/1/gpu/command_buffer/service/gl...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/15685003/diff/1/gpu/command_buffer/service/gl...
gpu/command_buffer/service/gles2_cmd_decoder.cc:3431: GLfloat scale_factor =
static_cast<GLuint>(c.scale_factor);
On 2013/05/22 19:41:14, piman wrote:
> static_cast<GLuint> is certainly wrong.
> I think you don't need a cast at all.

Ooof, embarrassing. Thanks -- done!

[piman, 2013-05-22 20:05:35]

lgtm

[ccameron, 2013-05-22 20:59:32]

Thanks!!

Adding raymes for ppapi OWNER stamp.

[raymes, 2013-05-22 22:39:54]

ppapi lgtm

On Wed, May 22, 2013 at 1:59 PM,  <ccameron@chromium.org> wrote:
> Thanks!!
>
> Adding raymes for ppapi OWNER stamp.
>
> https://codereview.chromium.org/15685003/

[ccameron, 2013-05-24 21:16:16]

Adding kbr for OWNER stamp on webkit/gpu changes.

[greggman, 2013-05-24 22:51:36]

lgtm

[ccameron, 2013-05-24 23:03:01]

Thanks!!

[commit-bot: I haz the power, 2013-05-24 23:03:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/15685003/7002

[commit-bot: I haz the power, 2013-05-24 23:14:37]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[ccameron, 2013-05-24 23:28:04]

** Presubmit Warnings **
License must match:
(...)
Found a bad license header in these files:
  ppapi/lib/gl/include/GLES2/gl2ext.h

Charming...

[commit-bot: I haz the power, 2013-05-25 17:06:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/15685003/33001

[commit-bot: I haz the power, 2013-05-26 02:05:12]

Change committed as 202325