Part 2/3 (GL) of adding with device scale factor to transport surfaces

ppapi/shared_impl/ppb_graphics_3d_shared.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/shared_impl/ppb_graphics_3d_shared.h"
 
 #include "base/logging.h"
 #include "gpu/command_buffer/client/gles2_cmd_helper.h"
 #include "gpu/command_buffer/client/gles2_implementation.h"
 #include "gpu/command_buffer/client/transfer_buffer.h"
@@ skipping 33 matching lines @@
 int32_t PPB_Graphics3D_Shared::GetError() {
   // TODO(alokp): Implement me.
   return PP_ERROR_FAILED;
 }
 
 int32_t PPB_Graphics3D_Shared::ResizeBuffers(int32_t width, int32_t height) {
   if ((width < 0) || (height < 0))
     return PP_ERROR_BADARGUMENT;
 
   ScopedNoLocking already_locked(this);
-  gles2_impl()->ResizeCHROMIUM(width, height);
+  gles2_impl()->ResizeCHROMIUM(width, height, 1.f);

[ccameron, 2013/05/22 08:38:31]

This seemed questionable to me, put pepper flash worked transitioning between
hidpi and non-hidpi screens, and going in and out of fullscreen on both.

[piman, 2013/05/22 19:41:14]

It's ok. Hi-DPI is handled separately in Flash. Also, the scale factor is
actually ignored in the decoder for the "parenting" case - see the is_offscreen
case in GLES2DecoderImpl::HandleResizeCHROMIUM

   // TODO(alokp): Check if resize succeeded and return appropriate error code.
   return PP_OK;
 }
 
 int32_t PPB_Graphics3D_Shared::SwapBuffers(
     scoped_refptr<TrackedCallback> callback) {
   ScopedNoLocking already_locked(this);
   if (HasPendingSwap()) {
     Log(PP_LOGLEVEL_ERROR, "PPB_Graphics3D.SwapBuffers: Plugin attempted swap "
                            "with previous swap still pending.");
@@ skipping 90 matching lines @@
 void PPB_Graphics3D_Shared::PushAlreadyLocked() {
   // Do nothing. This should be overridden in the plugin side.
 }
 
 void PPB_Graphics3D_Shared::PopAlreadyLocked() {
   // Do nothing. This should be overridden in the plugin side.
 }
 
 }  // namespace ppapi