Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 156843005: Set scissor to clip bounding box when using GrConvexPolyEffect (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Set scissor to clip bounding box when using GrConvexPolyEffect BUG=skia:2051 Committed: http://code.google.com/p/skia/source/detail?r=13361

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/gpu/GrClipMaskManager.cpp View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
This recovers the perf on the N10. https://codereview.chromium.org/156843005/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/156843005/diff/1/src/gpu/GrClipMaskManager.cpp#newcode177 src/gpu/GrClipMaskManager.cpp:177: SkIRect scissorSpaceIBounds(clipSpaceIBounds); ...
6 years, 10 months ago (2014-02-06 22:16:01 UTC) #1
robertphillips
lgtm https://codereview.chromium.org/156843005/diff/1/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/156843005/diff/1/src/gpu/GrClipMaskManager.cpp#newcode177 src/gpu/GrClipMaskManager.cpp:177: SkIRect scissorSpaceIBounds(clipSpaceIBounds); That's a better answer then them ...
6 years, 10 months ago (2014-02-07 13:42:10 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-07 13:53:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/156843005/1
6 years, 10 months ago (2014-02-07 13:53:15 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 14:04:50 UTC) #5
Message was sent while issue was closed.
Change committed as 13361

Powered by Google App Engine
This is Rietveld 408576698